add --no-color option to disable colors in the terminal (#518)

add --no-color option to disable colors

this commit adds a new option to disable colors in the terminal and also
moves the logger configuration to a different crate.

Signed-off-by: Sebastian Webber <sebastian@swebber.me>

src/cmd_args.rs

@@ -13,6 +13,15 @@ pub struct Args {
 
     #[clap(short='F', long, value_enum, default_value_t=LogFormat::Text, env)]
     pub log_format: LogFormat,
+
+    #[arg(
+        short,
+        long,
+        default_value_t = false,
+        env,
+        help = "disable colors in the log output"
+    )]
+    pub no_color: bool,
 }
 
 pub fn parse() -> Args {

src/lib.rs

@@ -6,6 +6,7 @@ pub mod config;
 pub mod constants;
 pub mod dns_cache;
 pub mod errors;
+pub mod logger;
 pub mod messages;
 pub mod mirrors;
 pub mod plugins;

src/logger.rs

@@ -0,0 +1,14 @@
+use crate::cmd_args::{Args, LogFormat};
+use tracing_subscriber;
+
+pub fn init(args: &Args) {
+    let trace_sub = tracing_subscriber::fmt()
+        .with_max_level(args.log_level)
+        .with_ansi(!args.no_color);
+
+    match args.log_format {
+        LogFormat::Structured => trace_sub.json().init(),
+        LogFormat::Debug => trace_sub.pretty().init(),
+        _ => trace_sub.init(),
+    };
+}

src/main.rs

@@ -62,30 +62,17 @@ use std::sync::Arc;
 use tokio::sync::broadcast;
 
 use pgcat::cmd_args;
-use pgcat::cmd_args::LogFormat;
 use pgcat::config::{get_config, reload_config, VERSION};
 use pgcat::dns_cache;
+use pgcat::logger;
 use pgcat::messages::configure_socket;
 use pgcat::pool::{ClientServerMap, ConnectionPool};
 use pgcat::prometheus::start_metric_server;
 use pgcat::stats::{Collector, Reporter, REPORTER};
-use tracing_subscriber;
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
     let args = cmd_args::parse();
-    match args.log_format {
+    logger::init(&args);
-        LogFormat::Structured => tracing_subscriber::fmt()
-            .json()
-            .with_max_level(args.log_level)
-            .init(),
-        LogFormat::Debug => tracing_subscriber::fmt()
-            .pretty()
-            .with_max_level(args.log_level)
-            .init(),
-        _ => tracing_subscriber::fmt()
-            .with_max_level(args.log_level)
-            .init(),
-    };
 
     info!("Welcome to PgCat! Meow. (Version {})", VERSION);