From 50654c2ae9fc9cf44a420c4b78525b9442961584 Mon Sep 17 00:00:00 2001 From: Mohammad Dashti Date: Fri, 6 Oct 2023 13:21:07 -0700 Subject: [PATCH] Added `clippy` to CI. --- .circleci/config.yml | 3 +++ CONTRIBUTING.md | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index c834491..0722411 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -63,6 +63,9 @@ jobs: - run: name: "Lint" command: "cargo fmt --check" + - run: + name: "Clippy" + command: "cargo clippy --all --all-targets -- -Dwarnings" - run: name: "Tests" command: "cargo clean && cargo build && cargo test && bash .circleci/run_tests.sh && .circleci/generate_coverage.sh" diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 10d4924..e0d5d16 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -2,7 +2,7 @@ Thank you for contributing! Just a few tips here: -1. `cargo fmt` your code before opening up a PR +1. `cargo fmt` and `cargo clippy` your code before opening up a PR 2. Run the test suite (e.g. `pgbench`) to make sure everything still works. The tests are in `.circleci/run_tests.sh`. 3. Performance is important, make sure there are no regressions in your branch vs. `main`.