From 7a419f40ea8ebb3adfb33602e969542c1ce0ace9 Mon Sep 17 00:00:00 2001
From: Lev <lev.kokotov@gmail.com>
Date: Mon, 4 Dec 2023 19:59:53 -0800
Subject: [PATCH] Revert "Require a reason when marking a server bad (#654)"

This reverts commit 4dbef49ec986973b4cd92b71513c4ba0c99f4369.
---
 src/client.rs  | 16 +++++++---------
 src/mirrors.rs | 10 ++++------
 src/pool.rs    |  2 +-
 src/server.rs  |  4 ++--
 4 files changed, 14 insertions(+), 18 deletions(-)

diff --git a/src/client.rs b/src/client.rs
index 23392b7..bbeb526 100644
--- a/src/client.rs
+++ b/src/client.rs
@@ -1437,7 +1437,7 @@ where
                             .await
                             {
                                 // We might be in some kind of error/in between protocol state
-                                server.mark_bad(err.to_string().as_str());
+                                server.mark_bad();
                                 return Err(err);
                             }
 
@@ -1504,7 +1504,7 @@ where
                         match write_all_flush(&mut self.write, &response).await {
                             Ok(_) => (),
                             Err(err) => {
-                                server.mark_bad(err.to_string().as_str());
+                                server.mark_bad();
                                 return Err(err);
                             }
                         };
@@ -1926,7 +1926,7 @@ where
                 Ok(_) => (),
                 Err(err) => {
                     // We might be in some kind of error/in between protocol state, better to just kill this server
-                    server.mark_bad(err.to_string().as_str());
+                    server.mark_bad();
                     return Err(err);
                 }
             };
@@ -1993,13 +1993,11 @@ where
                 }
             },
             Err(_) => {
-                server.mark_bad(
-                    format!(
-                        "Statement timeout while talking to {:?} with user {}",
-                        address, pool.settings.user.username
-                    )
-                    .as_str(),
+                error!(
+                    "Statement timeout while talking to {:?} with user {}",
+                    address, pool.settings.user.username
                 );
+                server.mark_bad();
                 pool.ban(address, BanReason::StatementTimeout, Some(client_stats));
                 error_response_terminal(&mut self.write, "pool statement timeout").await?;
                 Err(Error::StatementTimeout)
diff --git a/src/mirrors.rs b/src/mirrors.rs
index 73ab732..5c39504 100644
--- a/src/mirrors.rs
+++ b/src/mirrors.rs
@@ -85,9 +85,8 @@ impl MirroredClient {
                         match recv_result {
                             Ok(message) => trace!("Received from mirror: {} {:?}", String::from_utf8_lossy(&message[..]), address.clone()),
                             Err(err) => {
-                                server.mark_bad(
-                                    format!("Failed to send to mirror, Discarding message {:?}, {:?}", err, address.clone()).as_str()
-                                );
+                                server.mark_bad();
+                                error!("Failed to receive from mirror {:?} {:?}", err, address.clone());
                             }
                         }
                     }
@@ -99,9 +98,8 @@ impl MirroredClient {
                                 match server.send(&BytesMut::from(&bytes[..])).await {
                                     Ok(_) => trace!("Sent to mirror: {} {:?}", String::from_utf8_lossy(&bytes[..]), address.clone()),
                                     Err(err) => {
-                                        server.mark_bad(
-                                            format!("Failed to receive from mirror {:?} {:?}", err, address.clone()).as_str()
-                                        );
+                                        server.mark_bad();
+                                        error!("Failed to send to mirror, Discarding message {:?}, {:?}", err, address.clone())
                                     }
                                 }
                             }
diff --git a/src/pool.rs b/src/pool.rs
index 00f4dc2..751f187 100644
--- a/src/pool.rs
+++ b/src/pool.rs
@@ -871,7 +871,7 @@ impl ConnectionPool {
         }
 
         // Don't leave a bad connection in the pool.
-        server.mark_bad("failed health check");
+        server.mark_bad();
 
         self.ban(address, BanReason::FailedHealthCheck, Some(client_info));
         false
diff --git a/src/server.rs b/src/server.rs
index 882450e..9089b56 100644
--- a/src/server.rs
+++ b/src/server.rs
@@ -1279,8 +1279,8 @@ impl Server {
     }
 
     /// Indicate that this server connection cannot be re-used and must be discarded.
-    pub fn mark_bad(&mut self, reason: &str) {
-        error!("Server {:?} marked bad, reason: {}", self.address, reason);
+    pub fn mark_bad(&mut self) {
+        error!("Server {:?} marked bad", self.address);
         self.bad = true;
     }