Fix default_role being ignored when query_parser_enabled was false

charts/pgcat/Chart.yaml

@@ -5,4 +5,4 @@ maintainers:
   - name: Wildcard
     email: support@w6d.io
 appVersion: "1.2.0"
-version: 0.2.4
+version: 0.2.1

cr.yaml

@@ -1,2 +1 @@
 sign: false
-pages_branch: main

pgcat.toml

@@ -179,8 +179,7 @@ primary_reads_enabled = true
 # `random`: picks a shard at random
 # `random_healthy`: picks a shard at random favoring shards with the least number of recent errors
 # `shard_<number>`: e.g. shard_0, shard_4, etc. picks a specific shard, everytime
-# `fail`: fails to pick up shard. (require explicit shard setup)
+# no_shard_specified_behavior = "shard_0"
-# default_shard = "shard_0"
 
 # So what if you wanted to implement a different hashing function,
 # or you've already built one and you want this pooler to use it?

src/config.rs

@@ -773,7 +773,6 @@ pub enum DefaultShard {
     Shard(usize),
     Random,
     RandomHealthy,
-    Fail,
 }
 impl Default for DefaultShard {
     fn default() -> Self {
@@ -788,7 +787,6 @@ impl serde::Serialize for DefaultShard {
             }
             DefaultShard::Random => serializer.serialize_str("random"),
             DefaultShard::RandomHealthy => serializer.serialize_str("random_healthy"),
-            DefaultShard::Fail => serializer.serialize_str("fail"),
         }
     }
 }
@@ -806,7 +804,6 @@ impl<'de> serde::Deserialize<'de> for DefaultShard {
         match s.as_str() {
             "random" => Ok(DefaultShard::Random),
             "random_healthy" => Ok(DefaultShard::RandomHealthy),
-            "fail" => Ok(DefaultShard::Fail),
             _ => Err(serde::de::Error::custom(
                 "invalid value for no_shard_specified_behavior",
             )),

src/errors.rs

@@ -30,7 +30,6 @@ pub enum Error {
     QueryRouterError(String),
     InvalidShardId(usize),
     PreparedStatementError,
-    NoShardSelected,
 }
 
 #[derive(Clone, PartialEq, Debug)]

src/pool.rs

@@ -720,7 +720,6 @@ impl ConnectionPool {
                             .unwrap()
                     });
                 }
-                DefaultShard::Fail => return Err(Error::NoShardSelected),
             },
         };