github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-27 00:46:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

repmgrd: fixes to failover handling

Browse Source 
get_new_primary() returns NULL if no notification for the new primary has
been received, but the code was expecting it to return UNKNOWN_NODE_ID,
which was causing repmgrd to prematurely drop out of the new primary
detection loop if no notification had been received by the time the loop
started.

Also store the electoral term as a single row, single column table,
to ensure that all repmgrds see the same turn. It is then bumped
by the winning node after it gets promoted.

Various logging improvements.
This commit is contained in:
Ian Barwick
2017-11-08 14:19:52 +09:00
parent de1eb3c459
commit 03b9475755
5 changed files with 134 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
repmgr.c
View File

@@ -427,6 +427,7 @@ get_voting_status(PG_FUNCTION_ARGS)
#endif
}
Datum
set_voting_status_initiated(PG_FUNCTION_ARGS)
{
@@ -434,7 +435,12 @@ set_voting_status_initiated(PG_FUNCTION_ARGS)
int electoral_term = -1;
if (!shared_state)
PG_RETURN_NULL();
PG_RETURN_VOID();
if (PG_ARGISNULL(0))
PG_RETURN_VOID();
electoral_term = PG_GETARG_INT32(0);
LWLockAcquire(shared_state->lock, LW_SHARED);
@@ -445,21 +451,18 @@ set_voting_status_initiated(PG_FUNCTION_ARGS)
LWLockAcquire(shared_state->lock, LW_EXCLUSIVE);
shared_state->voting_status = VS_VOTE_INITIATED;
shared_state->current_electoral_term += 1;
electoral_term = shared_state->current_electoral_term;
shared_state->current_electoral_term = electoral_term;
elog(INFO, "setting voting term to %i", electoral_term);
}
LWLockRelease(shared_state->lock);
PG_RETURN_INT32(electoral_term);
#else
PG_RETURN_INT32(-1);
#endif
PG_RETURN_VOID();
}
Datum
other_node_is_candidate(PG_FUNCTION_ARGS)
{