github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-25 16:16:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Update code comments

Browse Source
This commit is contained in:
Ian Barwick
2016-07-12 10:56:31 +09:00
parent 3db87e6a31
commit 0a8a043c71
1 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
repmgr.c
View File

@@ -5804,7 +5804,9 @@ param_set(const char *param, const char *value)
int c; int c;
int value_len = strlen(value) + 1; int value_len = strlen(value) + 1;
// scan array for param /*
* Scan array to see if the parameter is already set - if so replace it
*/
for (c = 0; c <= param_count && param_keywords[c] != NULL; c++) for (c = 0; c <= param_count && param_keywords[c] != NULL; c++)
{ {
if (strcmp(param_keywords[c], param) == 0) if (strcmp(param_keywords[c], param) == 0)
@@ -5812,20 +5814,29 @@ param_set(const char *param, const char *value)
if (param_values[c] != NULL) if (param_values[c] != NULL)
pfree(param_values[c]); pfree(param_values[c]);
param_values[c] = pg_malloc(value_len); param_values[c] = pg_malloc0(value_len);
strncpy(param_values[c], value, value_len); strncpy(param_values[c], value, value_len);
return; return;
} }
} }
/*
* Parameter not in array - add it and its associated value
*/
if (c < param_count) if (c < param_count)
{ {
int param_len = strlen(param) + 1; int param_len = strlen(param) + 1;
param_keywords[c] = pg_malloc(param_len); param_keywords[c] = pg_malloc0(param_len);
param_values[c] = pg_malloc(value_len); param_values[c] = pg_malloc0(value_len);
strncpy(param_keywords[c], param, param_len); strncpy(param_keywords[c], param, param_len);
strncpy(param_values[c], value, value_len); strncpy(param_values[c], value, value_len);
} }
/*
* It's theoretically possible a parameter couldn't be added as
* the array is full, but it's highly improbable so we won't
* handle it at the moment.
*/
} }