From 0b7dbb845c2ea38346a04c71867b0d929667a57d Mon Sep 17 00:00:00 2001
From: Ian Barwick <ian@2ndquadrant.com>
Date: Mon, 28 Aug 2017 15:10:57 +0900
Subject: [PATCH] Add warning for --dry-run when not effective

---
 repmgr-client.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/repmgr-client.c b/repmgr-client.c
index 4ab8d16d..135fda89 100644
--- a/repmgr-client.c
+++ b/repmgr-client.c
@@ -1514,6 +1514,24 @@ check_cli_parameters(const int action)
 		}
 	}
 
+	if (runtime_options.dry_run == true)
+	{
+		switch (action)
+		{
+			case PRIMARY_REGISTER:
+			case PRIMARY_UNREGISTER:
+			case STANDBY_CLONE:
+			case STANDBY_SWITCHOVER:
+			case NODE_SERVICE:
+				break;
+			default:
+				item_list_append_format(
+					&cli_warnings,
+					_("--dry-run is not effective when executing %s"),
+					action_name(action));
+		}
+	}
+
 	/* check only one of --csv, --nagios and --optformat  used */
 	{
 		int used_options = 0;