github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-26 16:46:28 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

"witness register": fix primary node check

Browse Source 
Addresses GitHub #377, based on report by user yonj1e in #373.
This commit is contained in:
Ian Barwick
2018-02-08 16:28:50 +09:00
parent d3e1937808
commit 0b8755e278
3 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
HISTORY
View File

@@ -18,6 +18,7 @@
repmgr: fix parsing of "pg_basebackup_options"; GitHub #376 (Ian) repmgr: fix parsing of "pg_basebackup_options"; GitHub #376 (Ian)
repmgr: ensure "pg_subtrans" directory is created when cloning a standby in repmgr: ensure "pg_subtrans" directory is created when cloning a standby in
Barman mode (Ian) Barman mode (Ian)
repmgr: fix primary node check in "witness register"; GitHub #377 (Ian)
4.0.2 2018-01-18 4.0.2 2018-01-18
repmgr: add missing -W option to getopt_long() invocation; GitHub #350 (Ian) repmgr: add missing -W option to getopt_long() invocation; GitHub #350 (Ian)

6
doc/appendix-release-notes.sgml
View File

@@ -122,6 +122,12 @@
</para> </para>
</listitem> </listitem>
<listitem>
<para>
<command><link linkend="repmgr-witness-register">repmgr witness register</link></command>:
fix primary node check (GitHub #377).
</para>
</listitem>
</itemizedlist> </itemizedlist>
</para> </para>

4
repmgr-action-witness.c
View File

@@ -110,12 +110,12 @@ do_witness_register(void)
} }
/* check primary node's recovery type */ /* check primary node's recovery type */
recovery_type = get_recovery_type(witness_conn); recovery_type = get_recovery_type(primary_conn);
if (recovery_type == RECTYPE_STANDBY) if (recovery_type == RECTYPE_STANDBY)
{ {
log_error(_("provided primary node is a standby")); log_error(_("provided primary node is a standby"));
log_error(_("provide the connection details of the cluster's primary server")); log_hint(_("provide the connection details of the cluster's primary server"));
PQfinish(witness_conn); PQfinish(witness_conn);
PQfinish(primary_conn); PQfinish(primary_conn);