github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-26 16:46:28 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Remove unnecessary get_server_version() calls in do_standby_clone()

Browse Source 
We cache the value at the start of the function, and it's reasonable to
assume that the server version is not going to suddenly change.
This commit is contained in:
Ian Barwick
2016-06-06 23:41:47 +09:00
parent 005640be51
commit 0d42b771f5
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
repmgr.c
View File

@@ -1412,7 +1412,7 @@ do_standby_clone(void)
if (*runtime_options.recovery_min_apply_delay) if (*runtime_options.recovery_min_apply_delay)
{ {
if (get_server_version(upstream_conn, NULL) < 90400) if (server_version_num < 90400)
{ {
log_err(_("PostgreSQL 9.4 or greater required for --recovery-min-apply-delay\n")); log_err(_("PostgreSQL 9.4 or greater required for --recovery-min-apply-delay\n"));
PQfinish(upstream_conn); PQfinish(upstream_conn);
@@ -1436,7 +1436,7 @@ do_standby_clone(void)
{ {
TablespaceListCell *cell; TablespaceListCell *cell;
if (get_server_version(upstream_conn, NULL) < 90400 && !runtime_options.rsync_only) if (server_version_num < 90400 && !runtime_options.rsync_only)
{ {
log_err(_("in PostgreSQL 9.3, tablespace mapping can only be used in conjunction with --rsync-only\n")); log_err(_("in PostgreSQL 9.3, tablespace mapping can only be used in conjunction with --rsync-only\n"));
PQfinish(upstream_conn); PQfinish(upstream_conn);
@@ -1878,7 +1878,7 @@ do_standby_clone(void)
} }
else else
{ {
r = run_basebackup(local_data_directory, get_server_version(upstream_conn, NULL)); r = run_basebackup(local_data_directory, server_version_num);
if (r != 0) if (r != 0)
{ {
log_warning(_("standby clone: base backup failed\n")); log_warning(_("standby clone: base backup failed\n"));