github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-26 16:46:28 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

repmgr: prevent involuntary cloning where no repmgr schema present on master

Browse Source
This commit is contained in:
Ian Barwick
2016-10-19 20:26:55 +09:00
parent 3f7c30b84d
commit 20d66df0ef
1 changed files with 24 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
repmgr.c
View File

@@ -2730,6 +2730,27 @@ do_standby_clone(void)
} }
/*
* Sanity-check that the master node has a repmgr schema - if not
* present, fail with an error (unless -F/--force is used)
*/
if (check_cluster_schema(primary_conn) == false)
{
if (!runtime_options.force)
{
/* schema doesn't exist */
log_err(_("expected repmgr schema '%s' not found on master server\n"), get_repmgr_schema());
log_hint(_("check that the master server was correctly registered\n"));
PQfinish(source_conn);
exit(ERR_BAD_CONFIG);
}
log_warning(_("expected repmgr schema '%s' not found on master server\n"), get_repmgr_schema());
}
/* Fetch the source's data directory */ /* Fetch the source's data directory */
if (get_pg_setting(source_conn, "data_directory", master_data_directory) == false) if (get_pg_setting(source_conn, "data_directory", master_data_directory) == false)
{ {
@@ -2751,6 +2772,8 @@ do_standby_clone(void)
log_hint(_("use -D/--data-dir to explicitly specify a data directory\n")); log_hint(_("use -D/--data-dir to explicitly specify a data directory\n"));
} }
/* /*
* Copy the source connection so that we have some default values, * Copy the source connection so that we have some default values,
* particularly stuff like passwords extracted from PGPASSFILE; * particularly stuff like passwords extracted from PGPASSFILE;
@@ -6106,6 +6129,7 @@ do_witness_register(PGconn *masterconn)
log_notice(_("configuration has been successfully copied to the witness\n")); log_notice(_("configuration has been successfully copied to the witness\n"));
} }
static void static void
do_witness_unregister(void) do_witness_unregister(void)
{ {