From 28c7737dc0d3d7524cde77d67e429886d0ba60c5 Mon Sep 17 00:00:00 2001 From: Ian Barwick Date: Fri, 30 Mar 2018 11:24:44 +0900 Subject: [PATCH] Log pg_control access errors as WARNINGs rather than DEBUG This will make it easier to diagnose issues, possibly with an incorrect "data_directory" setting in "repmgr.conf". --- controldata.c | 11 +++++++---- dbutils.c | 4 ++-- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/controldata.c b/controldata.c index 7bc7cfa4..2931a6d0 100644 --- a/controldata.c +++ b/controldata.c @@ -157,15 +157,18 @@ get_controlfile(const char *DataDir) if ((fd = open(ControlFilePath, O_RDONLY | PG_BINARY, 0)) == -1) { - log_debug("could not open file \"%s\" for reading: %s", - ControlFilePath, strerror(errno)); + log_warning(_("could not open file \"%s\" for reading"), + ControlFilePath); + log_detail("%s", strerror(errno)); return control_file_info; } if (read(fd, control_file_info->control_file, sizeof(ControlFileData)) != sizeof(ControlFileData)) { - log_debug("could not read file \"%s\": %s", - ControlFilePath, strerror(errno)); + log_warning(_("could not read file \"%s\""), + ControlFilePath); + log_detail("%s", strerror(errno)); + return control_file_info; } diff --git a/dbutils.c b/dbutils.c index b0964a4c..f7cf749b 100644 --- a/dbutils.c +++ b/dbutils.c @@ -1384,7 +1384,7 @@ can_use_pg_rewind(PGconn *conn, const char *data_directory, PQExpBufferData *rea appendPQExpBuffer(reason, "; "); appendPQExpBuffer(reason, - _("\"wal_log_hints\" is set to \"off\" but unable to determine checksum version")); + _("\"wal_log_hints\" is set to \"off\" but unable to determine data checksum version")); can_use = false; } else if (data_checksum_version == 0) @@ -1393,7 +1393,7 @@ can_use_pg_rewind(PGconn *conn, const char *data_directory, PQExpBufferData *rea appendPQExpBuffer(reason, "; "); appendPQExpBuffer(reason, - _("\"wal_log_hints\" is set to \"off\" and checksums are disabled")); + _("\"wal_log_hints\" is set to \"off\" and data checksums are disabled")); can_use = false; }