From 2a8861be8b914c9b9c72758d6c450c2002fee243 Mon Sep 17 00:00:00 2001 From: Gianni Ciolli Date: Thu, 18 Aug 2016 10:51:36 +0200 Subject: [PATCH] Fixing inaccurate option checking (#230) The incompatibility between Barman mode and use_replication_slots was not checked properly, and did not cause repmgr to exit. --- repmgr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/repmgr.c b/repmgr.c index 73261eec..d6c97504 100644 --- a/repmgr.c +++ b/repmgr.c @@ -863,9 +863,11 @@ main(int argc, char **argv) if (action == STANDBY_CLONE && ! runtime_options.without_barman - && strcmp(options.barman_server, "") == 0) + && strcmp(options.barman_server, "") != 0 + && options.use_replication_slots) { log_err(_("STANDBY CLONE in Barman mode is incompatible with configuration option \"use_replication_slots\"")); + exit(ERR_BAD_CONFIG); } /* Initialise the repmgr schema name */