github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-25 16:16:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

refactor query in function get_replication_info()

Browse Source 
In particular handle all cases where one of the functions called
in the query can return NULL in the query itself.
This commit is contained in:
Ian Barwick
2019-02-06 15:39:01 +09:00
parent b9cd321aed
commit 2b3b1faa20
1 changed files with 27 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
dbutils.c
View File

@@ -4730,26 +4730,41 @@ get_replication_info(PGconn *conn, ReplInfo *replication_info)
" CASE WHEN (last_wal_receive_lsn = last_wal_replay_lsn) " " CASE WHEN (last_wal_receive_lsn = last_wal_replay_lsn) "
" THEN 0::INT " " THEN 0::INT "
" ELSE " " ELSE "
" EXTRACT(epoch FROM (pg_catalog.clock_timestamp() - last_xact_replay_timestamp))::INT " " CASE WHEN last_xact_replay_timestamp IS NULL "
" THEN 0::INT "
" ELSE "
" EXTRACT(epoch FROM (pg_catalog.clock_timestamp() - last_xact_replay_timestamp))::INT "
" END "
" END AS replication_lag_time, " " END AS replication_lag_time, "
" COALESCE(last_wal_receive_lsn, '0/0') >= last_wal_replay_lsn AS receiving_streamed_wal " " last_wal_receive_lsn >= last_wal_replay_lsn AS receiving_streamed_wal "
" FROM ( "); " FROM ( "
" SELECT CURRENT_TIMESTAMP AS ts, "
" pg_catalog.pg_last_xact_replay_timestamp() AS last_xact_replay_timestamp, ");
if (PQserverVersion(conn) >= 100000) if (PQserverVersion(conn) >= 100000)
{ {
appendPQExpBufferStr(&query, appendPQExpBufferStr(&query,
" SELECT CURRENT_TIMESTAMP AS ts, " " COALESCE(pg_catalog.pg_last_wal_receive_lsn(), '0/0'::PG_LSN) AS last_wal_receive_lsn, "
" pg_catalog.pg_last_wal_receive_lsn() AS last_wal_receive_lsn, " " COALESCE(pg_catalog.pg_last_wal_replay_lsn(), '0/0'::PG_LSN) AS last_wal_replay_lsn ");
" pg_catalog.pg_last_wal_replay_lsn() AS last_wal_replay_lsn, "
" pg_catalog.pg_last_xact_replay_timestamp() AS last_xact_replay_timestamp ");
} }
else else
{ {
appendPQExpBufferStr(&query, if (PQserverVersion(conn) >= 90400)
" SELECT CURRENT_TIMESTAMP AS ts, " {
" pg_catalog.pg_last_xlog_receive_location() AS last_wal_receive_lsn, " appendPQExpBufferStr(&query,
" pg_catalog.pg_last_xlog_replay_location() AS last_wal_replay_lsn, " " COALESCE(pg_catalog.pg_last_xlog_receive_location(), '0/0'::PG_LSN) AS last_wal_receive_lsn, "
" pg_catalog.pg_last_xact_replay_timestamp() AS last_xact_replay_timestamp "); " COALESCE(pg_catalog.pg_last_xlog_replay_location(), '0/0'::PG_LSN) AS last_wal_replay_lsn ");
}
else
{
/* 9.3 does not have "pg_lsn" datatype */
appendPQExpBufferStr(&query,
" COALESCE(pg_catalog.pg_last_xlog_receive_location(), '0/0') AS last_wal_receive_lsn, "
" COALESCE(pg_catalog.pg_last_xlog_replay_location(), '0/0') AS last_wal_replay_lsn ");
}
} }
appendPQExpBufferStr(&query, appendPQExpBufferStr(&query,