github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-26 16:46:28 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

repmgrd: ensure potentially open connections are closed

Browse Source 
When recovering from degraded state in local node monitoring, in some
cases a new connection was opened to the local node without closing
the old one, which will result in memory leakage.
This commit is contained in:
zhouhj43183
2022-01-04 12:22:09 +09:00
committed by Ian Barwick
parent 81f9c0ebd0
commit 2dce8e14f9
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
repmgrd-physical.c
View File

@@ -585,6 +585,7 @@ monitor_streaming_primary(void)
if (is_server_available(local_node_info.conninfo) == true) if (is_server_available(local_node_info.conninfo) == true)
{ {
close_connection(&local_conn);
local_conn = establish_db_connection(local_node_info.conninfo, false); local_conn = establish_db_connection(local_node_info.conninfo, false);
if (PQstatus(local_conn) != CONNECTION_OK) if (PQstatus(local_conn) != CONNECTION_OK)
@@ -1813,7 +1814,10 @@ monitor_streaming_standby(void)
if (upstream_check_result == true) if (upstream_check_result == true)
{ {
if (config_file_options.connection_check_type != CHECK_QUERY) if (config_file_options.connection_check_type != CHECK_QUERY)
{
close_connection(&upstream_conn);
upstream_conn = establish_db_connection(upstream_node_info.conninfo, false); upstream_conn = establish_db_connection(upstream_node_info.conninfo, false);
}
if (PQstatus(upstream_conn) == CONNECTION_OK) if (PQstatus(upstream_conn) == CONNECTION_OK)
{ {
@@ -2546,8 +2550,10 @@ monitor_streaming_witness(void)
if (check_upstream_connection(&primary_conn, upstream_node_info.conninfo, NULL) == true) if (check_upstream_connection(&primary_conn, upstream_node_info.conninfo, NULL) == true)
{ {
if (config_file_options.connection_check_type != CHECK_QUERY) if (config_file_options.connection_check_type != CHECK_QUERY)
{
close_connection(&primary_conn);
primary_conn = establish_db_connection(upstream_node_info.conninfo, false); primary_conn = establish_db_connection(upstream_node_info.conninfo, false);
}
if (PQstatus(primary_conn) == CONNECTION_OK) if (PQstatus(primary_conn) == CONNECTION_OK)
{ {
PQExpBufferData event_details; PQExpBufferData event_details;