github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-27 00:46:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

node action: don't attempt to issue a CHECKPOINT as non-superuser

Browse Source 
Raise a warning instead.
This commit is contained in:
Ian Barwick
2020-03-24 16:36:50 +09:00
parent b09631b3bc
commit 304c1391cc
1 changed files with 28 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
repmgr-action-node.c
View File

@@ -2025,12 +2025,6 @@ do_node_service(void)
if ((action == ACTION_STOP || action == ACTION_RESTART) && runtime_options.checkpoint == true) if ((action == ACTION_STOP || action == ACTION_RESTART) && runtime_options.checkpoint == true)
{
if (runtime_options.dry_run == true)
{
log_info(_("a CHECKPOINT would be issued here"));
}
else
{ {
PGconn *conn = NULL; PGconn *conn = NULL;
@@ -2039,15 +2033,38 @@ do_node_service(void)
else else
conn = establish_db_connection_by_params(&source_conninfo, true); conn = establish_db_connection_by_params(&source_conninfo, true);
if (is_superuser_connection(conn, NULL) == false)
{
if (runtime_options.dry_run == true)
{
log_warning(_("a CHECKPOINT would be issued here but no superuser connection is available"));
}
else
{
log_warning(_("a superuser connection is required to issue a CHECKPOINT"));
}
log_hint(_("provide a superuser with -S/--superuser"));
}
else
{
if (runtime_options.dry_run == true)
{
log_info(_("a CHECKPOINT would be issued here"));
}
else
{
log_notice(_("issuing CHECKPOINT")); log_notice(_("issuing CHECKPOINT"));
/* check superuser conn! */
checkpoint(conn); checkpoint(conn);
PQfinish(conn);
} }
} }
PQfinish(conn);
}
get_server_action(action, command, data_dir); get_server_action(action, command, data_dir);
if (runtime_options.dry_run == true) if (runtime_options.dry_run == true)