From 311f7e561e7bbf2912719e2a7f29f0d57943467c Mon Sep 17 00:00:00 2001
From: Ian Barwick <ian@2ndquadrant.com>
Date: Wed, 28 Nov 2018 14:26:31 +0900
Subject: [PATCH] "standby switchover": use empheral witness server connection

Intended to prevent issue reported in GitHub #514.
---
 repmgr-action-standby.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/repmgr-action-standby.c b/repmgr-action-standby.c
index 0b9b5804..49513d0a 100644
--- a/repmgr-action-standby.c
+++ b/repmgr-action-standby.c
@@ -4169,6 +4169,8 @@ do_standby_switchover(void)
 
 			if (sibling_node_record.type == WITNESS)
 			{
+				PGconn *witness_conn = NULL;
+
 				/* TODO: create "repmgr witness resync" or similar */
 				appendPQExpBuffer(&remote_command_str,
 								  "witness register -d \\'%s\\' --force 2>/dev/null && echo \"1\" || echo \"0\"",
@@ -4181,13 +4183,13 @@ do_standby_switchover(void)
 				 *
 				 * In the unlikely event repmgrd is not running or not in use, this will have no effect.
 				 */
-				cell->node_info->conn = establish_db_connection_quiet(cell->node_info->conninfo);
+				witness_conn = establish_db_connection_quiet(cell->node_info->conninfo);
 
-				if (PQstatus(cell->node_info->conn) == CONNECTION_OK)
+				if (PQstatus(witness_conn) == CONNECTION_OK)
 				{
-					notify_follow_primary(cell->node_info->conn, local_node_record.node_id);
+					notify_follow_primary(witness_conn, local_node_record.node_id);
 				}
-				PQfinish(cell->node_info->conn);
+				PQfinish(witness_conn);
 			}
 			else
 			{