github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-26 08:36:30 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Use correct sizeof() argument in a couple of strncpy calls

Browse Source 
Source and destination buffers are however the same length in both cases.

Per GitHub #561.
This commit is contained in:
Ian Barwick
2019-04-04 10:58:00 +09:00
parent 4e8b94c105
commit 538d5f9df0
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
repmgr-action-cluster.c
View File

@@ -1065,7 +1065,7 @@ build_cluster_matrix(t_node_matrix_rec ***matrix_rec_dest, int *name_length, Ite
matrix_rec_list[i]->node_id = cell->node_info->node_id; matrix_rec_list[i]->node_id = cell->node_info->node_id;
strncpy(matrix_rec_list[i]->node_name, strncpy(matrix_rec_list[i]->node_name,
cell->node_info->node_name, cell->node_info->node_name,
sizeof(cell->node_info->node_name)); sizeof(matrix_rec_list[i]->node_name));
/* /*
* Find the maximum length of a node name * Find the maximum length of a node name
@@ -1280,7 +1280,7 @@ build_cluster_crosscheck(t_node_status_cube ***dest_cube, int *name_length, Item
cube[h] = (t_node_status_cube *) pg_malloc(sizeof(t_node_status_cube)); cube[h] = (t_node_status_cube *) pg_malloc(sizeof(t_node_status_cube));
cube[h]->node_id = cell->node_info->node_id; cube[h]->node_id = cell->node_info->node_id;
strncpy(cube[h]->node_name, cell->node_info->node_name, sizeof(cell->node_info->node_name)); strncpy(cube[h]->node_name, cell->node_info->node_name, sizeof(cube[h]->node_name));
/* /*
* Find the maximum length of a node name * Find the maximum length of a node name