From 63ddc2d39e1c2635158eea776258c2bc7342540f Mon Sep 17 00:00:00 2001
From: Ian Barwick <ian@2ndquadrant.com>
Date: Wed, 23 Oct 2019 14:44:51 +0900
Subject: [PATCH] Let _establish_db_connection() work with replication
 connections

Previously this was limited to establish_db_connection_by_params().
---
 dbutils.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/dbutils.c b/dbutils.c
index f95c60ed..ea7802e2 100644
--- a/dbutils.c
+++ b/dbutils.c
@@ -161,6 +161,7 @@ _establish_db_connection(const char *conninfo, const bool exit_on_error, const b
 	char	   *errmsg = NULL;
 
 	t_conninfo_param_list conninfo_params = T_CONNINFO_PARAM_LIST_INITIALIZER;
+	bool		is_replication_connection = false;
 	bool		parse_success = false;
 
 	initialize_conninfo_params(&conninfo_params, false);
@@ -179,6 +180,9 @@ _establish_db_connection(const char *conninfo, const bool exit_on_error, const b
 	param_set_ine(&conninfo_params, "connect_timeout", "2");
 	param_set_ine(&conninfo_params, "fallback_application_name", "repmgr");
 
+	if (param_get(&conninfo_params, "replication") != NULL)
+		is_replication_connection = true;
+
 	connection_string = param_list_to_string(&conninfo_params);
 
 	log_debug(_("connecting to: \"%s\""), connection_string);
@@ -224,7 +228,8 @@ _establish_db_connection(const char *conninfo, const bool exit_on_error, const b
 	 * XXX set this explicitly before any write operations
 	 */
 
-	else if (set_config(conn, "synchronous_commit", "local") == false)
+	else if (is_replication_connection == false &&
+			 set_config(conn, "synchronous_commit", "local") == false)
 	{
 		if (exit_on_error)
 		{