From 7428e92e106627848f8433f6d4208dbe65cd2b3f Mon Sep 17 00:00:00 2001 From: Christian Kruse Date: Tue, 7 Jan 2014 14:27:31 +0100 Subject: [PATCH] fix: correctly check the return value of PQexec() not only check if return value is not NULL but also check that the returned result is a PGRES_COMMAND_OK (e.g. the INSERT was successful) --- repmgr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/repmgr.c b/repmgr.c index 10b756f9..de9f0865 100644 --- a/repmgr.c +++ b/repmgr.c @@ -743,7 +743,8 @@ do_standby_register(void) options.conninfo, options.priority); log_debug(_("standby register: %s\n"), sqlquery); - if (!PQexec(master_conn, sqlquery)) + res = PQexec(master_conn, sqlquery); + if (!res || PQresultStatus(res) != PGRES_COMMAND_OK) { log_err(_("Cannot insert node details, %s\n"), PQerrorMessage(master_conn));