github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-27 17:06:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

repmgrd: never execute "service_promote_command" directly

Browse Source
This commit is contained in:
Ian Barwick
2017-08-02 12:09:25 +09:00
parent aa528dfdfb
commit 791640e3b4
1 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
repmgrd-physical.c
View File

@@ -113,10 +113,19 @@ do_physical_node_check(void)
bool required_param_missing = false; bool required_param_missing = false;
if (config_file_options.promote_command[0] == '\0' if (config_file_options.promote_command[0] == '\0')
&& config_file_options.service_promote_command[0] == '\0')
{ {
log_error(_("either \"promote_command\" or \"service_promote_command\" must be defined in the configuration file")); log_error(_("\"promote_command\" must be defined in the configuration file"));
if (config_file_options.service_promote_command[0] != '\0')
{
/*
* if repmgrd executes "service_promote_command" directly, repmgr metadata
* won't get updated
*/
log_hint(_("\"service_promote_command\" is set, but can only be executed by \"repmgr standby promote\""));
}
required_param_missing = true; required_param_missing = true;
} }
if (config_file_options.follow_command[0] == '\0') if (config_file_options.follow_command[0] == '\0')
@@ -1143,11 +1152,8 @@ promote_self(void)
return FAILOVER_STATE_PROMOTION_FAILED; return FAILOVER_STATE_PROMOTION_FAILED;
} }
/* the presence of either of these commands has been established already */ /* the presence of either of this command has been established already */
if (config_file_options.service_promote_command[0] != '\0') promote_command = config_file_options.promote_command;
promote_command = config_file_options.service_promote_command;
else
promote_command = config_file_options.promote_command;
log_debug("promote command is:\n \"%s\"", log_debug("promote command is:\n \"%s\"",
promote_command); promote_command);