github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-27 08:56:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

In configuration check, check that 'archive_command' is not empty

Browse Source
This commit is contained in:
Ian Barwick
2015-03-18 16:07:34 +09:00
parent 7bd54b5a70
commit 86d24759a0
1 changed files with 31 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
repmgr.c
View File

@@ -3031,8 +3031,8 @@ check_upstream_config(PGconn *conn, int server_version_num, bool exit_on_error)
int i; int i;
bool config_ok = true; bool config_ok = true;
char *wal_error_message = NULL; char *wal_error_message = NULL;
/* Check that WAL level is set correctly */
/* Check that WAL level is set correctly */
if(server_version_num < 90300) if(server_version_num < 90300)
{ {
i = guc_set(conn, "wal_level", "=", "hot_standby"); i = guc_set(conn, "wal_level", "=", "hot_standby");
@@ -3159,6 +3159,36 @@ check_upstream_config(PGconn *conn, int server_version_num, bool exit_on_error)
config_ok = false; config_ok = false;
} }
/*
* check that 'archive_command' is non empty (however it's not practical to
* check that it's actually valid)
*
* if 'archive_mode' is not on, pg_settings returns '(disabled)' regardless
* of what's in 'archive_command', so until 'archive_mode' is on we can't
* properly check it.
*/
if(guc_set(conn, "archive_mode", "=", "on"))
{
i = guc_set(conn, "archive_command", "!=", "");
if (i == 0 || i == -1)
{
if (i == 0)
log_err(_("parameter 'archive_command' must be set to a valid command\n"));
if(exit_on_error == true)
{
PQfinish(conn);
exit(ERR_BAD_CONFIG);
}
config_ok = false;
}
}
i = guc_set(conn, "hot_standby", "=", "on"); i = guc_set(conn, "hot_standby", "=", "on");
if (i == 0 || i == -1) if (i == 0 || i == -1)
{ {