github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-22 22:56:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

repmgrd: improve logging of promote_command failure

Browse Source 
- log failure *before* we check if the primary has reappeared
- log the error code
This commit is contained in:
Ian Barwick
2020-04-21 15:02:15 +09:00
parent 025e66ea46
commit 8adcb1348d
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
repmgrd-physical.c
View File

@@ -3438,6 +3438,8 @@ promote_self(void)
r = system(promote_command); r = system(promote_command);
log_debug("result of promote_command: %i", WEXITSTATUS(r));
/* connection should stay up, but check just in case */ /* connection should stay up, but check just in case */
if (PQstatus(local_conn) != CONNECTION_OK) if (PQstatus(local_conn) != CONNECTION_OK)
{ {
@@ -3456,9 +3458,14 @@ promote_self(void)
} }
} }
if (r != 0) if (WIFEXITED(r) && WEXITSTATUS(r))
{ {
int primary_node_id; int primary_node_id = UNKNOWN_NODE_ID;
log_error(_("promote command failed"));
log_detail(_("promote command exited with error code %i"), WEXITSTATUS(r));
log_info(_("checking if original primary node has reappeared"));
upstream_conn = get_primary_connection(local_conn, upstream_conn = get_primary_connection(local_conn,
&primary_node_id, &primary_node_id,
@@ -3493,8 +3500,7 @@ promote_self(void)
return FAILOVER_STATE_PRIMARY_REAPPEARED; return FAILOVER_STATE_PRIMARY_REAPPEARED;
} }
log_warning(_("promotion "));
log_error(_("promote command failed"));
create_event_notification(NULL, create_event_notification(NULL,
&config_file_options, &config_file_options,