github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-22 22:56:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

repmgr: prevent termination in corner-case situation

Browse Source 
If neither the local node nor the upstream are available, and
"standby_disconnect_on_failover" is set, attempting to fetch
the walreceiver PID will result in repmgrd terminating.

Add a check that the connection is valid before attempting to
fetch the walreceiver PID.

Addresses GitHub #675.
This commit is contained in:
Ian Barwick
2020-11-17 16:32:33 +09:00
parent 9c04de11fc
commit 8f7a32a9a2
2 changed files with 29 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
doc/appendix-release-notes.xml
View File

@@ -15,10 +15,32 @@
See also: <xref linkend="upgrading-repmgr"/> See also: <xref linkend="upgrading-repmgr"/>
</para> </para>
<sect1 id="release-5.2.1">
<title id="release-current">Release 5.2.1</title>
<para><emphasis>??? ?? ???, 2020</emphasis></para>
<para>
&repmgr; 5.2.1 is a minor release.
</para>
<sect2>
<title>Bug fixes</title>
<para>
<itemizedlist>
<listitem>
<para>
&repmgrd;: prevent termination when local node not available and
<option>standby_disconnect_on_failover</option> is set. GitHub #675.
</para>
</listitem>
</itemizedlist>
</para>
</sect2>
</sect1>
<!-- remember to update the release date in ../repmgr_version.h.in --> <!-- remember to update the release date in ../repmgr_version.h.in -->
<sect1 id="release-5.2.0"> <sect1 id="release-5.2.0">
<title id="release-current">Release 5.2.0</title> <title>Release 5.2.0</title>
<para><emphasis>Thu 22 October, 2020</emphasis></para> <para><emphasis>Thu 22 October, 2020</emphasis></para>
<para> <para>

6
sysutils.c
View File

@@ -363,6 +363,12 @@ enable_wal_receiver(PGconn *conn, bool wait_startup)
/* make timeout configurable */ /* make timeout configurable */
int i, timeout = 30; int i, timeout = 30;
if (PQstatus(conn) != CONNECTION_OK)
{
log_error(_("database connection not available"));
return UNKNOWN_PID;
}
if (is_superuser_connection(conn, NULL) == false) if (is_superuser_connection(conn, NULL) == false)
{ {
log_error(_("superuser connection required")); log_error(_("superuser connection required"));