From 9085ca46a8da20bd88774c18c1557f51b2906ceb Mon Sep 17 00:00:00 2001
From: Ian Barwick <ian@2ndquadrant.com>
Date: Tue, 28 May 2019 15:38:19 +0900
Subject: [PATCH] doc: update release notes

---
 HISTORY                            | 16 ++++++---
 doc/appendix-release-notes.xml     | 54 +++++++++++++++++++++++-------
 doc/repmgrd-automatic-failover.xml |  2 +-
 3 files changed, 55 insertions(+), 17 deletions(-)

diff --git a/HISTORY b/HISTORY
index 9d088ed9..9da08984 100644
--- a/HISTORY
+++ b/HISTORY
@@ -2,20 +2,28 @@
         repmgr: improve "daemon status" output (Ian)
         repmgr: add "--siblings-follow" option to "standby promote" (Ian)
         repmgr: add "--repmgrd-force-unpause" option to "standby switchover" (Ian)
+        repmgr: fix data directory permissions issue in barman mode where
+          an existing directory is being overwritten (Ian)
         repmgr: improve "--dry-run" behaviour for "standby promote" and
           "standby switchover" (Ian)
+        repmgr: ensure "--dry-run" together with --force when running "standby clone"
+          in barman mode does not modify an existing data directory (Ian)
+        repmgr: improve "--dry-run" output when running "standby clone" in
+          basebackup mode (Ian)
+        repmgr: improve upstream walsender checks when running "standby clone" (Ian)
         repmgr: display node timeline ID in "cluster show" output (Ian)
         repmgr: in "cluster show" and "daemon status", show upstream node name
           as reported by each individual node (Ian)
         repmgr: in "cluster show" and "daemon status", check if a node is attached
           to its advertised upstream node
         repmgr: prevent a standby being cloned from a witness server (Ian)
-        repmgrd: monitor standbys attached to primary (Ian)
+        repmgr: prevent a witness server being registered on the cluster primary (John)
         repmgr: ensure BDR2-specific functionality cannot be used on
           BDR3 and later (Ian)
-        repmgr: improve "--dry-run" behaviour in barman mode (Ian)
-        repmgr: fix data directory permissions issue in barman mode where
-          an existing directory is being overwritten (Ian)
+        repmgrd: monitor standbys attached to primary (Ian)
+        repmgrd: add "primary visibility consensus" functionality (Ian)
+        repmgrd: fix memory leak which occurs while the monitored PostgreSQL
+           node is not running (Ian)
         general: documentation converted to DocBook XML format (Ian)
 
 4.3     2019-04-02
diff --git a/doc/appendix-release-notes.xml b/doc/appendix-release-notes.xml
index 05187a07..700adba3 100644
--- a/doc/appendix-release-notes.xml
+++ b/doc/appendix-release-notes.xml
@@ -1,4 +1,3 @@
-
 <appendix id="appendix-release-notes">
   <title>Release notes</title>
   <indexterm>
@@ -18,13 +17,32 @@
 
   <sect1 id="release-4.4">
     <title>Release 4.4</title>
-    <para><emphasis>???, 2019</emphasis></para>
+    <para><emphasis>?? June, 2019</emphasis></para>
 
 	<sect2>
       <title>repmgr client enhancements</title>
       <para>
 	    <itemizedlist>
 
+		  <listitem>
+            <para>
+			  <link linkend="repmgr-standby-clone"><command>repmgr standby clone</command></link>:
+			  prevent a standby from being cloned from a witness server (PostgreSQL 9.6 and later only).
+			</para>
+		  </listitem>
+
+		  <listitem>
+            <para>
+			  <link linkend="repmgr-witness-register"><command>repmgr witness register</command></link>:
+			  prevent a witness server from being registered on the replication cluster primary server
+              (PostgreSQL 9.6 and later only).
+			</para>
+            <para>
+              Registering a witness on the primary node would defeat the purpose of having a witness server,
+              which is intended to remain running even if the cluster's primary goes down.
+            </para>
+		  </listitem>
+
           <listitem>
             <para>
               &repmgr;: when executing <link linkend="repmgr-standby-switchover"><command>repmgr standby switchover</command></link>,
@@ -52,7 +70,7 @@
             <para>
               <link linkend="repmgr-standby-switchover"><command>repmgr standby switchover</command></link>
               and <link linkend="repmgr-standby-promote"><command>repmgr standby promote</command></link>:
-              when executing with the <option>--dry-run</option>, continue checks as far as possible
+              when executing with the <option>--dry-run</option> option, continue checks as far as possible
               even if errors are encountered.
             </para>
           </listitem>
@@ -60,7 +78,8 @@
 
           <listitem>
             <para>
-              <link linkend="repmgr-standby-promote"><command>repmgr standby promote</command></link>: add <option>--siblings-follow</option> (similar to
+              <link linkend="repmgr-standby-promote"><command>repmgr standby promote</command></link>:
+              add <option>--siblings-follow</option> (similar to
               <link linkend="repmgr-standby-switchover"><command>repmgr standby switchover</command></link>).
             </para>
             <note>
@@ -71,7 +90,6 @@
                 via <option>promote_command</option>), <option>--siblings-follow</option>
                 <emphasis>must not</emphasis> be included as a
                 command line option for <link linkend="repmgr-standby-promote"><command>repmgr standby promote</command></link>.
-
               </para>
             </note>
           </listitem>
@@ -129,13 +147,6 @@
 			</para>
 		  </listitem>
 
-		  <listitem>
-            <para>
-			  <link linkend="repmgr-standby-clone"><command>repmgr standby clone</command></link>:
-			  prevent a standby from being cloned from a witness server.
-			</para>
-		  </listitem>
-
 		</itemizedlist>
 	  </para>
     </sect2>
@@ -151,12 +162,31 @@
               if the number of nodes connected falls below a certain (configurable) value,
               execute a custom script.
             </para>
+            <para>
+              This provided an additional method for fencing an isolated primary node, and/or taking
+              other action if one or more standys become disconnected.
+            </para>
             <para>
               See section <link linkend="repmgrd-primary-child-disconnection">Monitoring standby disconnections on the primary node</link>
               for more details.
             </para>
           </listitem>
 
+          <listitem>
+            <para>
+              In a failover situation, &repmgrd; nodes on the standbys of the failed primary
+              are now able confirm among themselves that none can still see the primary
+              before continuing with the failover.
+            </para>
+            <para>
+              The <filename>repmgr.conf</filename> option <option>primary_visibility_consensus</option> must
+              be set to <literal>true</literal> to enable this functionality.
+            </para>
+            <para>
+              See section <xref linkend="repmgrd-primary-visibility-consensus"/>
+              for more details.
+            </para>
+          </listitem>
         </itemizedlist>
       </para>
     </sect2>
diff --git a/doc/repmgrd-automatic-failover.xml b/doc/repmgrd-automatic-failover.xml
index 42b6ef88..bbd393eb 100644
--- a/doc/repmgrd-automatic-failover.xml
+++ b/doc/repmgrd-automatic-failover.xml
@@ -169,7 +169,7 @@
 </sect1>
 
 
-<sect1 id="repmgrd-primary-visibility-consensue" xreflabel="Primary visibility consensus">
+<sect1 id="repmgrd-primary-visibility-consensus" xreflabel="Primary visibility consensus">
   <title>Primary visibility consensus</title>
 
   <indexterm>