github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-25 08:06:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

standby clone: various clarifications for --replication-conf-only option

Browse Source 
In particular, the emitted HINT was not really appropriate for Pg13 and
later.
This commit is contained in:
Ian Barwick
2020-11-17 09:58:51 +09:00
parent 040b1ae4e3
commit 9c04de11fc
2 changed files with 32 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
doc/repmgr-standby-clone.xml
View File

@@ -260,16 +260,29 @@ pg_basebackup_options='--waldir=/path/to/wal-directory'</programlisting>
upstream node if required. upstream node if required.
</para> </para>
<para> <para>
Note that the upstream node must be running. In PostgreSQL 11 and earlier, an existing The upstream node must be running so the correct replication configuration can be obtained.
<filename>recovery.conf</filename> will not be overwritten unless the
<option>-F/--force</option> option is provided.
</para> </para>
<para> <para>
Execute <command>repmgr standby clone --replication-conf-only --dry-run</command> If the standby is running, the replication configuration will not be written unless the
to check the prerequisites for creating the recovery configuration, <option>-F/--force</option> option is provided.
and display the contents of the configuration which would be added without actually
making any changes.
</para> </para>
<tip>
<para>
Execute <command>repmgr standby clone --replication-conf-only --dry-run</command>
to check the prerequisites for creating the recovery configuration,
and display the configuration changes which would be made without actually
making any changes.
</para>
</tip>
<para>
In PostgreSQL 13 and later, the PostgreSQL configuration must be reloaded for replication
configuration changes to take effect.
</para>
<para>
In PostgreSQL 12 and earlier, the PostgreSQL instance must be restarted for replication
configuration changes to take effect.
</para>
</refsect1> </refsect1>

13
repmgr-action-standby.c
View File

@@ -1453,7 +1453,18 @@ _do_create_replication_conf(void)
if (node_is_running == true) if (node_is_running == true)
{ {
log_hint(_("node must be restarted for the new file to take effect")); if (PQserverVersion(upstream_conn) >= 130000)
{
log_hint(_("configuration must be reloaded for the configuration changes to take effect"));
}
else if (PQserverVersion(upstream_conn) >= 120000)
{
log_hint(_("node must be restarted for the configuration changes to take effect"));
}
else
{
log_hint(_("node must be restarted for the new file to take effect"));
}
} }
} }
} }