From a0937e959f33ba2c4a151c0ff4cdda9c4498deac Mon Sep 17 00:00:00 2001 From: Ian Barwick Date: Thu, 31 Aug 2017 23:26:55 +0900 Subject: [PATCH] "standby clone": fail if recovery.conf could not be created. Addresses GitHub #296 --- repmgr.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/repmgr.c b/repmgr.c index 1d46ff34..c6655dda 100644 --- a/repmgr.c +++ b/repmgr.c @@ -4087,7 +4087,16 @@ stop_backup: /* Finally, write the recovery.conf file */ - create_recovery_file(local_data_directory, &recovery_conninfo); + if (create_recovery_file( local_data_directory, &recovery_conninfo) == false) + { + /* create_recovery_file() will log an error */ + log_notice(_("unable to create recovery.conf; see preceding error messages\n")); + log_hint(_("data directory (\"%s\") may need to be cleaned up manually\n"), + local_data_directory); + + PQfinish(source_conn); + exit(ERR_BAD_CONFIG); + } if (mode == barman) {