From a5281d93dc6e55eb274fad718b2f7c51cae59b16 Mon Sep 17 00:00:00 2001 From: Ian Barwick Date: Tue, 3 Apr 2018 21:56:46 +0900 Subject: [PATCH] Add TODO for pg_rewind changes coming in PostgreSQL 11 --- repmgr-action-node.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/repmgr-action-node.c b/repmgr-action-node.c index d079c341..6bf93a5e 100644 --- a/repmgr-action-node.c +++ b/repmgr-action-node.c @@ -1913,7 +1913,16 @@ do_node_rejoin(void) } termPQExpBuffer(&filebuf); - /* delete any replication slots copied in by pg_rewind */ + /* + * Delete any replication slots copied in by pg_rewind. + * + * TODO: + * - from PostgreSQL 11, this will be handled by pg_rewind, so + * we can skip this step from that version; see commit + * 266b6acb312fc440c1c1a2036aa9da94916beac6 + * - possibly delete contents various other directories + * as per the above commit for pre-PostgreSQL 11 + */ { PQExpBufferData slotdir_path; DIR *slotdir;