github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-28 01:16:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

get_all_node_records(): display any error encountered and return success status

Browse Source 
In many cases we'll want to bail out with an error if the node list can't
be retrieved for any reason. This saves some repetitive coding.
This commit is contained in:
Ian Barwick
2018-06-26 10:44:31 +09:00
parent bb4fdcda98
commit b0a2ee2259
6 changed files with 41 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
repmgr-action-witness.c
View File

@@ -218,7 +218,13 @@ do_witness_register(void)
* if repmgr.nodes contains entries, delete if -F/--force provided,
* otherwise exit with error
*/
get_all_node_records(witness_conn, &nodes);
if (get_all_node_records(witness_conn, &nodes) == false)
{
/* get_all_node_records() will display the error */
PQfinish(witness_conn);
PQfinish(primary_conn);
exit(ERR_BAD_CONFIG);
}
log_verbose(LOG_DEBUG, "%i node records found", nodes.node_count);