github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-27 17:06:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

fix: do not exit() in create_pgdir()

Browse Source 
This could leave the database in a locked state (pg_start_backup()).
And since all calls to create_pgdir() handle the return value correctly
we simply replace the exit() by a return false
This commit is contained in:
Christian Kruse
2014-01-07 14:01:46 +01:00
parent 9209248420
commit b0cd2b5e43
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
check_dir.c
View File

@@ -256,7 +256,7 @@ create_pgdir(char *dir, bool force)
{ {
log_err(_("couldn't create directory \"%s\"...\n"), log_err(_("couldn't create directory \"%s\"...\n"),
dir); dir);
exit(ERR_BAD_CONFIG); return false;
} }
break; break;
case 1: case 1:
@@ -268,7 +268,7 @@ create_pgdir(char *dir, bool force)
{ {
log_err(_("could not change permissions of directory \"%s\": %s\n"), log_err(_("could not change permissions of directory \"%s\": %s\n"),
dir, strerror(errno)); dir, strerror(errno));
exit(ERR_BAD_CONFIG); return false;
} }
break; break;
case 2: case 2:
@@ -293,7 +293,7 @@ create_pgdir(char *dir, bool force)
"If you are sure you want to clone here, " "If you are sure you want to clone here, "
"please check there is no PostgreSQL server " "please check there is no PostgreSQL server "
"running and use the --force option\n")); "running and use the --force option\n"));
exit(ERR_BAD_CONFIG); return false;
} }
return false; return false;
@@ -301,7 +301,7 @@ create_pgdir(char *dir, bool force)
/* Trouble accessing directory */ /* Trouble accessing directory */
log_err(_("could not access directory \"%s\": %s\n"), log_err(_("could not access directory \"%s\": %s\n"),
dir, strerror(errno)); dir, strerror(errno));
exit(ERR_BAD_CONFIG); return false;
} }
return true; return true;
} }