github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-26 08:36:30 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Ensure BDR-specific code only runs on BDR 2.x

Browse Source 
The BDR support in repmgr is for a specific BDR 2.x use case, and
is not suitable for more recent BDR versions.
This commit is contained in:
Ian Barwick
2019-04-05 14:32:55 +09:00
committed by Ian Barwick
parent 01e11950a5
commit b7b9db7e9c
2 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
repmgr-action-bdr.c
View File

@@ -93,6 +93,15 @@ do_bdr_register(void)
exit(ERR_BAD_CONFIG); exit(ERR_BAD_CONFIG);
} }
if (get_bdr_version_num() > 2)
{
log_error(_("\"repmgr bdr register\" is for BDR 2.x only"));
PQfinish(conn);
pfree(dbname);
exit(ERR_BAD_CONFIG);
}
/* check for a matching BDR node */ /* check for a matching BDR node */
{ {
PQExpBufferData bdr_local_node_name; PQExpBufferData bdr_local_node_name;

12
repmgrd-bdr.c
View File

@@ -96,9 +96,21 @@ monitor_bdr(void)
if (!is_bdr_db(local_conn, NULL)) if (!is_bdr_db(local_conn, NULL))
{ {
log_error(_("database is not BDR-enabled")); log_error(_("database is not BDR-enabled"));
PQfinish(local_conn);
exit(ERR_BAD_CONFIG); exit(ERR_BAD_CONFIG);
} }
/*
* Check this is a supported BDR version (basically BDR 2.x)
*/
if (get_bdr_version_num() > 2)
{
log_error(_("\"bdr\" mode is for BDR 2.x only"));
log_hint(_("for BDR 3 and later, use \"replication_type=physical\""));
log_error(_("database is not BDR-enabled"));
exit(ERR_DB_CONN);
}
if (is_table_in_bdr_replication_set(local_conn, "nodes", "repmgr") == false) if (is_table_in_bdr_replication_set(local_conn, "nodes", "repmgr") == false)
{ {
log_error(_("repmgr metadata table 'repmgr.%s' is not in the 'repmgr' replication set"), log_error(_("repmgr metadata table 'repmgr.%s' is not in the 'repmgr' replication set"),