github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-26 16:46:28 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

"standby switchover": don't use --ignore-external-config-files

Browse Source 
It's deprecated. Do however pass "--copy-external-config-files" if
specified.

Per GitHub #310.
This commit is contained in:
Ian Barwick
2017-08-31 16:20:03 +09:00
parent 2264848601
commit b92d0cc696
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
repmgr.c
View File

@@ -5536,9 +5536,15 @@ do_standby_switchover(void)
appendPQExpBuffer(&remote_command_str, " -f "); appendPQExpBuffer(&remote_command_str, " -f ");
appendShellString(&remote_command_str, runtime_options.remote_config_file); appendShellString(&remote_command_str, runtime_options.remote_config_file);
appendPQExpBuffer(&remote_command_str, appendPQExpBuffer(&remote_command_str,
" %s --rsync-only --force --ignore-external-config-files standby clone", " %s --rsync-only --force standby clone",
repmgr_db_cli_params); repmgr_db_cli_params);
if (runtime_options.copy_external_config_files == true)
{
appendPQExpBuffer(&remote_command_str,
" --copy-external-config-files");
}
log_debug("Executing:\n%s\n", remote_command_str.data); log_debug("Executing:\n%s\n", remote_command_str.data);
initPQExpBuffer(&command_output); initPQExpBuffer(&command_output);
@@ -7369,7 +7375,8 @@ check_parameters_for_action(const int action)
item_list_append(&cli_warnings, _("-c/--fast-checkpoint can only be used when executing STANDBY CLONE")); item_list_append(&cli_warnings, _("-c/--fast-checkpoint can only be used when executing STANDBY CLONE"));
} }
if (runtime_options.copy_external_config_files) /* can be used for "standby switchover" too */
if (action != STANDBY_SWITCHOVER && runtime_options.copy_external_config_files)
{ {
item_list_append(&cli_warnings, _("--copy-external-config-files can only be used when executing STANDBY CLONE")); item_list_append(&cli_warnings, _("--copy-external-config-files can only be used when executing STANDBY CLONE"));
} }