From bb0aac8912fa07bfcf56eeea49893b17d8cd6951 Mon Sep 17 00:00:00 2001 From: Ian Barwick Date: Fri, 5 May 2017 19:03:33 +0900 Subject: [PATCH] "standby clone": rsync mode does of course accept -c/--fast-checkpoint --- repmgr-action-standby.c | 12 ++++++++---- repmgr-client.c | 7 ------- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/repmgr-action-standby.c b/repmgr-action-standby.c index abadfeba..9eb2bbc5 100644 --- a/repmgr-action-standby.c +++ b/repmgr-action-standby.c @@ -293,10 +293,6 @@ do_standby_clone(void) break; case pg_basebackup: log_notice(_("starting backup (using pg_basebackup)...")); - if (runtime_options.fast_checkpoint == false) - { - log_hint(_("this may take some time; consider using the -c/--fast-checkpoint option")); - } break; case barman: log_notice(_("getting backup from Barman...")); @@ -306,6 +302,14 @@ do_standby_clone(void) log_error(_("unknown clone mode")); } + if (mode == pg_basebackup || mode == rsync) + { + if (runtime_options.fast_checkpoint == false) + { + log_hint(_("this may take some time; consider using the -c/--fast-checkpoint option")); + } + } + if (mode == pg_basebackup) { r = run_basebackup(); diff --git a/repmgr-client.c b/repmgr-client.c index 0b62cf70..5d1d6de1 100644 --- a/repmgr-client.c +++ b/repmgr-client.c @@ -907,13 +907,6 @@ check_cli_parameters(const int action) item_list_append(&cli_warnings, _("--no-upstream-connection only effective in Barman mode")); } - - if (runtime_options.fast_checkpoint && runtime_options.rsync_only) - { - item_list_append(&cli_warnings, - _("-c/--fast-checkpoint has no effect when using -r/--rsync-only")); - } - } } break;