github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-27 17:06:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

"standby clone": improve log messages

Browse Source 
Make it clearer which nodes are being connected to, and why.
This commit is contained in:
Ian Barwick
2017-09-06 10:15:52 +09:00
parent e21a3ef7ec
commit bd07a34472
2 changed files with 16 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
dbutils.c
View File

@@ -1094,7 +1094,7 @@ _get_primary_connection(PGconn *conn,
} }
/* find all registered nodes */ /* find all registered nodes */
log_verbose(LOG_INFO, _("retrieving node list")); log_verbose(LOG_INFO, _("searching for primary node"));
initPQExpBuffer(&query); initPQExpBuffer(&query);
appendPQExpBuffer(&query, appendPQExpBuffer(&query,
@@ -1125,7 +1125,7 @@ _get_primary_connection(PGconn *conn,
node_id = atoi(PQgetvalue(res, i, 0)); node_id = atoi(PQgetvalue(res, i, 0));
strncpy(remote_conninfo, PQgetvalue(res, i, 1), MAXCONNINFO); strncpy(remote_conninfo, PQgetvalue(res, i, 1), MAXCONNINFO);
log_verbose(LOG_INFO, log_verbose(LOG_INFO,
_("checking role of node %i"), _("checking if node %i is primary"),
node_id); node_id);
if (quiet) if (quiet)
@@ -1158,7 +1158,7 @@ _get_primary_connection(PGconn *conn,
if (recovery_type == RECTYPE_PRIMARY) if (recovery_type == RECTYPE_PRIMARY)
{ {
PQclear(res); PQclear(res);
log_debug(_("get_primary_connection(): current primary node is %i"), node_id); log_verbose(LOG_INFO, _("current primary node is %i"), node_id);
if (primary_id != NULL) if (primary_id != NULL)
{ {

15
repmgr-action-standby.c
View File

@@ -212,8 +212,10 @@ do_standby_clone(void)
if (runtime_options.no_upstream_connection == false) if (runtime_options.no_upstream_connection == false)
{ {
/* /*
* This performs sanity checks on the upstream node, also * This connects to the source node and performs sanity checks, also
* sets "recovery_conninfo_str" and "upstream_repluser" * sets "recovery_conninfo_str", "upstream_repluser" and "upstream_node_id".
*
* Will error out if source connection not possible and not in "barman" mode.
*/ */
check_source_server(); check_source_server();
} }
@@ -437,6 +439,15 @@ do_standby_clone(void)
if (runtime_options.dry_run == true) if (runtime_options.dry_run == true)
{ {
if (upstream_node_id != UNKNOWN_NODE_ID)
{
log_notice(_("standby will attach to upstream node %i"), upstream_node_id);
}
else
{
log_warning(_("unable to determine a valid upstream node id"));
}
if (mode == pg_basebackup && runtime_options.fast_checkpoint == false) if (mode == pg_basebackup && runtime_options.fast_checkpoint == false)
{ {
log_hint(_("consider using the -c/--fast-checkpoint option")); log_hint(_("consider using the -c/--fast-checkpoint option"));