github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-24 23:56:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Log text of failed queries at log level ERROR

Browse Source 
Previously query texts were always logged at log level DEBUG, but
that doesn't help much in a normal production environment when
trying to identify the cause of issues.

Also make various other minor improvements to query logging and
handling of database errors.

Implements GitHub #498.
This commit is contained in:
Ian Barwick
2018-08-27 13:10:42 +09:00
parent 457dbbd267
commit c2dded1d7b
5 changed files with 359 additions and 308 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
HISTORY
View File

@@ -1,4 +1,6 @@
4.1.1 2018-??-?? 4.1.1 2018-??-??
logging: explicitly log the text of failed queries as ERRORs to
assist logfile analysis; GitHub #498
repmgr: truncate version string, if necessary; GitHub #490 (Ian) repmgr: truncate version string, if necessary; GitHub #490 (Ian)
repmgr: improve messages emitted during "standby promote" (Ian) repmgr: improve messages emitted during "standby promote" (Ian)
repmgr: "standby clone" - don't copy external config files in --dry-run repmgr: "standby clone" - don't copy external config files in --dry-run

637
dbutils.c
View File

File diff suppressed because it is too large Load Diff

10
doc/appendix-release-notes.sgml
View File

@@ -17,7 +17,7 @@
<sect1 id="release-4.1.1"> <sect1 id="release-4.1.1">
<title>Release 4.1.1</title> <title>Release 4.1.1</title>
<para><emphasis>??? ??? ??, 2018</emphasis></para> <para><emphasis>Wed September 5, 2018</emphasis></para>
<para> <para>
</para> </para>
@@ -33,6 +33,14 @@
</para> </para>
</listitem> </listitem>
<listitem>
<para>
Text of any failed queries will now be logged as <literal>ERROR</literal> to assist
logfile analysis at log levels higher than <literal>DEBUG</literal>.
(GitHub #498).
</para>
</listitem>
</itemizedlist> </itemizedlist>
</para> </para>
</sect2> </sect2>

8
repmgr-action-cluster.c
View File

@@ -1346,7 +1346,13 @@ do_cluster_cleanup(void)
entries_to_delete = get_number_of_monitoring_records_to_delete(primary_conn, runtime_options.keep_history); entries_to_delete = get_number_of_monitoring_records_to_delete(primary_conn, runtime_options.keep_history);
if (entries_to_delete == 0) if (entries_to_delete < 0)
{
log_error(_("unable to query number of monitoring records to clean up"));
PQfinish(primary_conn);
exit(ERR_DB_QUERY);
}
else if (entries_to_delete == 0)
{ {
log_info(_("no monitoring records to delete")); log_info(_("no monitoring records to delete"));
PQfinish(primary_conn); PQfinish(primary_conn);

10
repmgr-action-primary.c
View File

@@ -64,12 +64,10 @@ do_primary_register(void)
PQfinish(conn); PQfinish(conn);
exit(ERR_BAD_CONFIG); exit(ERR_BAD_CONFIG);
} }
else
{ log_error(_("unable to determine server's recovery type"));
log_error(_("connection to node lost")); PQfinish(conn);
PQfinish(conn); exit(ERR_DB_CONN);
exit(ERR_DB_CONN);
}
} }
log_verbose(LOG_INFO, _("server is not in recovery")); log_verbose(LOG_INFO, _("server is not in recovery"));