github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-26 08:36:30 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Add some missing query error logging

Browse Source
This commit is contained in:
Ian Barwick
2019-02-23 16:54:07 +09:00
committed by Ian Barwick
parent 07097575b1
commit c30e65b3f2
1 changed files with 23 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
dbutils.c
View File

@@ -1503,6 +1503,8 @@ identify_system(PGconn *repl_conn, t_system_identification *identification)
if (PQresultStatus(res) != PGRES_TUPLES_OK || !PQntuples(res)) if (PQresultStatus(res) != PGRES_TUPLES_OK || !PQntuples(res))
{ {
log_db_error(repl_conn, NULL, _("unable to execute IDENTIFY_SYSTEM"));
PQclear(res); PQclear(res);
return false; return false;
} }
@@ -1621,6 +1623,7 @@ repmgrd_set_local_node_id(PGconn *conn, int local_node_id)
{ {
PQExpBufferData query; PQExpBufferData query;
PGresult *res = NULL; PGresult *res = NULL;
bool success = true;
initPQExpBuffer(&query); initPQExpBuffer(&query);
@@ -1629,16 +1632,18 @@ repmgrd_set_local_node_id(PGconn *conn, int local_node_id)
local_node_id); local_node_id);
res = PQexec(conn, query.data); res = PQexec(conn, query.data);
termPQExpBuffer(&query);
if (PQresultStatus(res) != PGRES_TUPLES_OK) if (PQresultStatus(res) != PGRES_TUPLES_OK)
{ {
PQclear(res); log_db_error(conn, query.data, _("repmgrd_set_local_node_id(): unable to execute query"));
return false;
success = false;
} }
termPQExpBuffer(&query);
PQclear(res); PQclear(res);
return true;
return success;
} }
@@ -2082,6 +2087,8 @@ _get_node_record(PGconn *conn, char *sqlquery, t_node_info *node_info, bool init
if (PQresultStatus(res) != PGRES_TUPLES_OK) if (PQresultStatus(res) != PGRES_TUPLES_OK)
{ {
log_db_error(conn, sqlquery, _("_get_node_record(): unable to execute query"));
PQclear(res); PQclear(res);
return RECORD_ERROR; return RECORD_ERROR;
} }
@@ -2991,13 +2998,15 @@ update_node_record_conn_priority(PGconn *conn, t_configuration_options *options)
options->node_id); options->node_id);
res = PQexec(conn, query.data); res = PQexec(conn, query.data);
termPQExpBuffer(&query);
if (PQresultStatus(res) != PGRES_COMMAND_OK) if (PQresultStatus(res) != PGRES_COMMAND_OK)
{ {
log_db_error(conn, query.data, _("update_node_record_conn_priority(): unable to execute query"));
success = false; success = false;
} }
termPQExpBuffer(&query);
PQclear(res); PQclear(res);
return success; return success;
@@ -4647,6 +4656,11 @@ get_primary_current_lsn(PGconn *conn)
{ {
ptr = parse_lsn(PQgetvalue(res, 0, 0)); ptr = parse_lsn(PQgetvalue(res, 0, 0));
} }
else
{
log_db_error(conn, NULL, _("unable to execute get_primary_current_lsn()"));
}
PQclear(res); PQclear(res);
@@ -4673,6 +4687,10 @@ get_last_wal_receive_location(PGconn *conn)
{ {
ptr = parse_lsn(PQgetvalue(res, 0, 0)); ptr = parse_lsn(PQgetvalue(res, 0, 0));
} }
else
{
log_db_error(conn, NULL, _("unable to execute get_last_wal_receive_location()"));
}
PQclear(res); PQclear(res);
@@ -5072,7 +5090,6 @@ set_primary_last_seen(PGconn *conn)
termPQExpBuffer(&query); termPQExpBuffer(&query);
PQclear(res); PQclear(res);
} }