github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-25 16:16:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Add some todos

Browse Source
This commit is contained in:
Ian Barwick
2017-05-04 23:49:55 +09:00
parent bb362bdb7e
commit c41ff2c442
2 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
repmgr-action-standby.c
View File

@@ -1100,6 +1100,7 @@ run_basebackup(void)
*/ */
if (runtime_options.conninfo_provided == true) if (runtime_options.conninfo_provided == true)
{ {
// XXX need to override user with runtime_options.replication_user!
appendPQExpBuffer(&params, " -d '%s'", runtime_options.dbname); appendPQExpBuffer(&params, " -d '%s'", runtime_options.dbname);
} }

7
repmgr-client.c
View File

@@ -1802,6 +1802,13 @@ check_upstream_config(PGconn *conn, int server_version_num, bool exit_on_error)
if (possible_replication_connections < min_replication_connections) if (possible_replication_connections < min_replication_connections)
{ {
config_ok = false; config_ok = false;
/*
* XXX at this point we could check current_setting('max_wal_senders) - COUNT(*) FROM pg_stat_replication;
* if >= min_replication_connections we could infer possible authentication error.
*
* Alternatively call PQconnectStart() and poll for presence/absence of CONNECTION_AUTH_OK ?
*/
log_error(_("unable to establish necessary replication connections")); log_error(_("unable to establish necessary replication connections"));
log_hint(_("increase 'max_wal_senders' by at least %i"), min_replication_connections - possible_replication_connections); log_hint(_("increase 'max_wal_senders' by at least %i"), min_replication_connections - possible_replication_connections);