github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-22 22:56:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

cluster show: display timeline ID

Browse Source 
This helps provide a better picture of the state of the cluster, i.e.
making it more obvious whether there's been a timeline divergence.

This also provides infrastructure for further improvements in cluster
status display and diagnosis.

Note this is only available in PostgreSQL 9.6 and later as it relies
on the SQL functions for interrogating pg_control, which can be executed
remotely. As PostgreSQL 9.5 will shortly be the only community-supported
version without these functions, it's not worth the effort of trying
to duplicate their functionality.
This commit is contained in:
Ian Barwick
2019-05-27 09:15:12 +09:00
parent df6d160d2e
commit c560dfbbce
6 changed files with 133 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
repmgr-action-cluster.c
View File

@@ -24,7 +24,7 @@
#include "repmgr-client-global.h"
#include "repmgr-action-cluster.h"
#define SHOW_HEADER_COUNT 8
#define SHOW_HEADER_COUNT 9
typedef enum
{
@@ -35,6 +35,7 @@ typedef enum
SHOW_UPSTREAM_NAME,
SHOW_LOCATION,
SHOW_PRIORITY,
SHOW_TIMELINE_ID,
SHOW_CONNINFO
} ShowHeader;
@@ -113,9 +114,15 @@ do_cluster_show(void)
strncpy(headers_show[SHOW_LOCATION].title, _("Location"), MAXLEN);
if (runtime_options.compact == true)
{
strncpy(headers_show[SHOW_PRIORITY].title, _("Prio."), MAXLEN);
strncpy(headers_show[SHOW_TIMELINE_ID].title, _("TLI"), MAXLEN);
}
else
{
strncpy(headers_show[SHOW_PRIORITY].title, _("Priority"), MAXLEN);
strncpy(headers_show[SHOW_TIMELINE_ID].title, _("Timeline"), MAXLEN);
}
strncpy(headers_show[SHOW_CONNINFO].title, _("Connection string"), MAXLEN);
@@ -128,6 +135,16 @@ do_cluster_show(void)
{
headers_show[i].display = true;
/* Don't display timeline on pre-9.6 clusters */
if (i == SHOW_TIMELINE_ID)
{
if (PQserverVersion(conn) < 90600)
{
headers_show[i].display = false;
}
}
/* if --compact provided, don't display conninfo */
if (runtime_options.compact == true)
{
if (i == SHOW_CONNINFO)
@@ -136,6 +153,7 @@ do_cluster_show(void)
}
}
if (headers_show[i].display == true)
{
headers_show[i].max_length = strlen(headers_show[i].title);
@@ -154,6 +172,15 @@ do_cluster_show(void)
PQExpBufferData upstream;
PQExpBufferData buf;
cell->node_info->replication_info = palloc0(sizeof(ReplInfo));
if (cell->node_info->replication_info == NULL)
{
log_error(_("unable to allocate memory"));
exit(ERR_INTERNAL);
}
init_replication_info(cell->node_info->replication_info);
cell->node_info->conn = establish_db_connection_quiet(cell->node_info->conninfo);
if (PQstatus(cell->node_info->conn) != CONNECTION_OK)
@@ -176,6 +203,11 @@ do_cluster_show(void)
cell->node_info->node_name, cell->node_info->node_id);
}
}
else
{
/* NOP on pre-9.6 servers */
cell->node_info->replication_info->timeline_id = get_node_timeline(cell->node_info->conn);
}
initPQExpBuffer(&node_status);
initPQExpBuffer(&upstream);
@@ -212,7 +244,18 @@ do_cluster_show(void)
headers_show[SHOW_LOCATION].cur_length = strlen(cell->node_info->location);
if (cell->node_info->replication_info->timeline_id == UNKNOWN_TIMELINE_ID)
{
/* display "?" */
headers_show[SHOW_PRIORITY].cur_length = 1;
}
else
{
initPQExpBuffer(&buf);
appendPQExpBuffer(&buf, "%i", cell->node_info->replication_info->timeline_id);
headers_show[SHOW_PRIORITY].cur_length = strlen(buf.data);
termPQExpBuffer(&buf);
}
headers_show[SHOW_CONNINFO].cur_length = strlen(cell->node_info->conninfo);
@@ -277,6 +320,14 @@ do_cluster_show(void)
printf("| %-*s ", headers_show[SHOW_LOCATION].max_length, cell->node_info->location);
printf("| %-*i ", headers_show[SHOW_PRIORITY].max_length, cell->node_info->priority);
if (headers_show[SHOW_TIMELINE_ID].display == true)
{
if (cell->node_info->replication_info->timeline_id == UNKNOWN_TIMELINE_ID)
printf("| %-*c ", headers_show[SHOW_TIMELINE_ID].max_length, '?');
else
printf("| %-*i ", headers_show[SHOW_TIMELINE_ID].max_length, (int)cell->node_info->replication_info->timeline_id);
}
if (headers_show[SHOW_CONNINFO].display == true)
{
printf("| %-*s", headers_show[SHOW_CONNINFO].max_length, cell->node_info->conninfo);