From d00cb767a643ee8bc2e34fcfe21c33f914063461 Mon Sep 17 00:00:00 2001 From: Ian Barwick Date: Tue, 12 Feb 2019 10:15:06 +0900 Subject: [PATCH] cluster show: don't try to run WAL replay pause query on unreachable node --- repmgr-action-cluster.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/repmgr-action-cluster.c b/repmgr-action-cluster.c index d9595533..d37d7cc9 100644 --- a/repmgr-action-cluster.c +++ b/repmgr-action-cluster.c @@ -294,6 +294,14 @@ do_cluster_show(void) cell->node_info->node_name, cell->node_info->node_id); } } + + /* warn about issue with paused WAL replay */ + if (is_wal_replay_paused(cell->node_info->conn, true)) + { + item_list_append_format(&warnings, + _("WAL replay is paused on node \"%s\" (ID: %i) with WAL replay pending; this node cannot be manually promoted until WAL replay is resumed"), + cell->node_info->node_name, cell->node_info->node_id); + } } /* node is unreachable */ else @@ -313,13 +321,6 @@ do_cluster_show(void) } } - /* warn about issue with paused WAL replay */ - if (is_wal_replay_paused(cell->node_info->conn, true)) - { - item_list_append_format(&warnings, - _("WAL replay is paused on node \"%s\" (ID: %i) with WAL replay pending; this node cannot be manually promoted until WAL replay is resumed"), - cell->node_info->node_name, cell->node_info->node_id); - } } break;