github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-26 16:46:28 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Reject parameters with empty values.

Browse Source
This commit is contained in:
Ian Barwick
2015-03-08 00:12:33 +09:00
parent a55587d75a
commit d7365535ab
1 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
config.c
View File

@@ -140,6 +140,8 @@ parse_config(const char *config_file, t_configuration_options *options)
/* Read next line */ /* Read next line */
while ((s = fgets(buff, sizeof buff, fp)) != NULL) while ((s = fgets(buff, sizeof buff, fp)) != NULL)
{ {
bool known_parameter = true;
/* Skip blank lines and comments */ /* Skip blank lines and comments */
if (buff[0] == '\n' || buff[0] == '#') if (buff[0] == '\n' || buff[0] == '#')
continue; continue;
@@ -213,7 +215,22 @@ parse_config(const char *config_file, t_configuration_options *options)
else if (strcmp(name, "tablespace_mapping") == 0) else if (strcmp(name, "tablespace_mapping") == 0)
tablespace_list_append(options, value); tablespace_list_append(options, value);
else else
{
known_parameter = false;
log_warning(_("%s/%s: Unknown name/value pair!\n"), name, value); log_warning(_("%s/%s: Unknown name/value pair!\n"), name, value);
}
/*
* Raise an error if a known parameter is provided with an empty value.
* Currently there's no reason why empty parameters are needed; if
* we want to accept those, we'd need to add stricter default checking,
* as currently e.g. an empty `node` value will be converted to '0'.
*/
if(known_parameter == true && !strlen(value)) {
log_err(_("No value provided for parameter '%s'. Check the configuration file.\n"), name);
exit(ERR_BAD_CONFIG);
}
} }
/* Close file */ /* Close file */