github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-25 08:06:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Changed pg_version() prototype in order to remove the small memory leak

Browse Source
This commit is contained in:
Gabriele Bartolini
2010-12-16 22:48:19 +01:00
parent f2bec9a08f
commit d88783a4d9
5 changed files with 20 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
dbutils.c
View File

@@ -64,10 +64,9 @@ is_standby(PGconn *conn)
* if 8 or inferior returns an empty string
*/
char *
pg_version(PGconn *conn)
pg_version(PGconn *conn, char* major_version)
{
PGresult *res;
char *major_version;
int major_version1;
char *major_version2;
@@ -85,12 +84,10 @@ pg_version(PGconn *conn)
major_version2 = PQgetvalue(res, 0, 1);
PQclear(res);
/* FIX: this is never deallocated */
major_version = malloc(10);
if (major_version1 >= 9)
{
/* form a major version string */
sprintf(major_version, "%d.%s", major_version1, major_version2);
snprintf(major_version, MAXVERSIONSTR, "%d.%s", major_version1, major_version2);
}
else
strcpy(major_version, "");