mirror of
https://github.com/EnterpriseDB/repmgr.git
synced 2026-03-26 00:26:30 +00:00
Remove option "--wal-keep-segments"
This is a remnant of the early repmgr days when there were no alternative mechanisms for ensuring sufficient WAL remains available while cloning a standby. The purpose of this setting was to override a check for an (arbitrary) minimum setting for "wal_keep_segments". As there's no reliable way of determining a sensible value for this, and improvements in pg_basebackup mean WALs can be streamed (possibly using a replication slot) while the backup is in progress, there's no point in keeping this around. We will however still emit a warning about setting "wal_keep_segments" if the configuration doesn't appear to provide any other way of ensuring WAL is available during/after the cloning process and "wal_keep_segments" is not set.
This commit is contained in:
@@ -22,7 +22,6 @@ typedef struct
|
||||
bool connection_param_provided;
|
||||
bool host_param_provided;
|
||||
bool limit_provided;
|
||||
bool wal_keep_segments_used;
|
||||
|
||||
/* general configuration options */
|
||||
char config_file[MAXPGPATH];
|
||||
@@ -68,7 +67,6 @@ typedef struct
|
||||
char upstream_conninfo[MAXLEN];
|
||||
int upstream_node_id;
|
||||
bool use_recovery_conninfo_password;
|
||||
char wal_keep_segments[MAXLEN];
|
||||
bool without_barman;
|
||||
|
||||
/* "standby register" options */
|
||||
@@ -111,7 +109,7 @@ typedef struct
|
||||
|
||||
#define T_RUNTIME_OPTIONS_INITIALIZER { \
|
||||
/* configuration metadata */ \
|
||||
false, false, false, false, false, \
|
||||
false, false, false, false, \
|
||||
/* general configuration options */ \
|
||||
"", false, false, "", false, \
|
||||
/* logging options */ \
|
||||
@@ -126,7 +124,7 @@ typedef struct
|
||||
UNKNOWN_NODE_ID, "", "", \
|
||||
/* "standby clone" options */ \
|
||||
false, CONFIG_FILE_SAMEPATH, false, false, false, "", "", "", \
|
||||
NO_UPSTREAM_NODE, false, "", false, \
|
||||
NO_UPSTREAM_NODE, false, false, \
|
||||
/* "standby register" options */ \
|
||||
false, 0, \
|
||||
/* "standby switchover" options */ \
|
||||
|
||||
Reference in New Issue
Block a user