github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-27 17:06:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

"standby switchover": epxlictly confirm suitability for --pg-rewind

Browse Source 
If --force-rewind requested.
This commit is contained in:
Ian Barwick
2017-08-28 14:50:08 +09:00
parent 4ba2291cdd
commit e05bab8284
1 changed files with 23 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
repmgr-action-standby.c
View File

@@ -1766,6 +1766,7 @@ do_standby_switchover(void)
if (runtime_options.force_rewind == true) if (runtime_options.force_rewind == true)
{ {
PQExpBufferData reason; PQExpBufferData reason;
PQExpBufferData msg;
initPQExpBuffer(&reason); initPQExpBuffer(&reason);
@@ -1779,9 +1780,22 @@ do_standby_switchover(void)
exit(ERR_BAD_CONFIG); exit(ERR_BAD_CONFIG);
} }
termPQExpBuffer(&reason); termPQExpBuffer(&reason);
initPQExpBuffer(&msg);
appendPQExpBuffer(&msg,
_("pre-requisites for using pg_rewind are met"));
if (runtime_options.dry_run == true)
{
log_info("%s", msg.data);
}
else
{
log_verbose(LOG_INFO, "%s", msg.data);
}
termPQExpBuffer(&msg);
get_datadir_configuration_files(remote_conn, &remote_config_files); get_datadir_configuration_files(remote_conn, &remote_config_files);
} }
@@ -1960,8 +1974,6 @@ do_standby_switchover(void)
log_debug("lag is %i ", lag_seconds); log_debug("lag is %i ", lag_seconds);
termPQExpBuffer(&command_output);
if (lag_seconds >= config_file_options.replication_lag_critical) if (lag_seconds >= config_file_options.replication_lag_critical)
{ {
if (runtime_options.force == false) if (runtime_options.force == false)
@@ -2192,6 +2204,10 @@ do_standby_switchover(void)
log_info(_("following shutdown command would be run on node \"%s\":\n \"%s\""), log_info(_("following shutdown command would be run on node \"%s\":\n \"%s\""),
remote_node_record.node_name, remote_node_record.node_name,
shutdown_command); shutdown_command);
clear_node_info_list(&sibling_nodes);
key_value_list_free(&remote_config_files);
return; return;
} }
@@ -2337,6 +2353,8 @@ do_standby_switchover(void)
appendPQExpBuffer(&node_rejoin_options, " "); appendPQExpBuffer(&node_rejoin_options, " ");
} }
key_value_list_free(&remote_config_files);
initPQExpBuffer(&remote_command_str); initPQExpBuffer(&remote_command_str);
make_remote_repmgr_path(&remote_command_str, &remote_node_record); make_remote_repmgr_path(&remote_command_str, &remote_node_record);
@@ -2458,10 +2476,10 @@ do_standby_switchover(void)
/* TODO: double-check all expected nodes are in pg_stat_replication and /* TODO: double-check all expected nodes are in pg_stat_replication and
* entries in repmgr.nodes match * entries in repmgr.nodes match
*/ */
clear_node_info_list(&sibling_nodes);
} }
clear_node_info_list(&sibling_nodes);
PQfinish(local_conn); PQfinish(local_conn);
log_notice(_("STANDBY SWITCHOVER is complete")); log_notice(_("STANDBY SWITCHOVER is complete"));