From e7acb6809bd3cf9c46e86d03052a79a54854b564 Mon Sep 17 00:00:00 2001 From: Ian Barwick Date: Thu, 8 Oct 2020 10:44:34 +0900 Subject: [PATCH] standby clone: improve error logging When executing "repmgr standby clone" in Barman mode, and --waldir is set in pg_basebackup options, properly report an error if the target WAL directory could not be created or is not empty. --- repmgr-action-standby.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/repmgr-action-standby.c b/repmgr-action-standby.c index 62a9e687..a16fc5df 100644 --- a/repmgr-action-standby.c +++ b/repmgr-action-standby.c @@ -7226,7 +7226,9 @@ run_file_backup(t_node_info *local_node_record) { if (create_pg_dir(backup_options.waldir, false) == false) { - /* create_pg_dir() will log any errors */ + /* create_pg_dir() will log specifics */ + log_error(_("unable to create an empty directory for WAL files")); + log_hint(_("see preceding error messages")); exit(ERR_BAD_CONFIG); }