From f006a79af971b3a886ac54277bf8349d1bffcca2 Mon Sep 17 00:00:00 2001 From: Ian Barwick Date: Tue, 13 Jan 2015 14:53:55 +0900 Subject: [PATCH] Clean up log messages for invalid LSNs --- repmgrd.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/repmgrd.c b/repmgrd.c index 5d709dd7..4a619d5c 100644 --- a/repmgrd.c +++ b/repmgrd.c @@ -1065,14 +1065,17 @@ do_failover(void) */ if(xlog_recptr == InvalidXLogRecPtr) { - log_debug("Invalid LSN returned - '%s'", PQgetvalue(res, 0, 0)); - if(lsn_format_ok == false) { /* Unable to parse value returned by `repmgr_get_last_standby_location()` */ if(*PQgetvalue(res, 0, 0) == '\0') { - log_crit("Whoops, seems as if shared_preload_libraries=repmgr_funcs is not set!\n"); + log_crit( + _("Unable to obtain LSN from node %i"), nodes[i].node_id + ); + log_info( + _("Please check that 'shared_preload_libraries=repmgr_funcs' is set\n") + ); exit(ERR_BAD_CONFIG); } @@ -1083,6 +1086,14 @@ do_failover(void) log_warning(_("Unable to parse LSN \"%s\"\n"), PQgetvalue(res, 0, 0)); } + else + { + log_debug( + _("Invalid LSN returned from node %i: '%s'\n"), + nodes[i].node_id, + PQgetvalue(res, 0, 0) + ); + } PQclear(res); PQfinish(node_conn);