Improve parameter validation, logging, and error

handling in repmgrd
This commit is contained in:
Greg Smith
2011-02-24 18:13:16 -05:00
parent c7b62003b2
commit f928edf897
4 changed files with 50 additions and 25 deletions

View File

@@ -30,6 +30,12 @@ parse_config(const char* config_file, t_configuration_options* options)
FILE *fp = fopen (config_file, "r");
/* Initialize */
memset(options->cluster_name, 0, sizeof(options->cluster_name));
options->node = -1;
memset(options->conninfo, 0, sizeof(options->conninfo));
memset(options->rsync_options, 0, sizeof(options->rsync_options));
/*
* Since some commands don't require a config file at all, not
* having one isn't necessarily a problem.
@@ -40,12 +46,6 @@ parse_config(const char* config_file, t_configuration_options* options)
return;
}
/* Initialize */
memset(options->cluster_name, 0, sizeof(options->cluster_name));
options->node = -1;
memset(options->conninfo, 0, sizeof(options->conninfo));
memset(options->rsync_options, 0, sizeof(options->rsync_options));
/* Read next line */
while ((s = fgets (buff, sizeof buff, fp)) != NULL)
{