Commit Graph

923 Commits

Author SHA1 Message Date
Ian Barwick 0f86bdcd05 Fixes for event logging
We can't always assume a valid connection to the master
2015-03-31 14:15:29 +09:00
Ian Barwick 7d33c1e411 Only attempt to log an event if the rempgr schema has been set
In some circumstances (primarily when executing `repmgr standby
clone`) the `repmgr.conf` file is not mandated. However this means
the repmgr schema is not known, and any attempt to create an
event record will result in a log warning, which may cause
confusion as to the success of the operation.

It might be better to mandate providing `repmgr.conf` in all
circumstances.

Per report in https://github.com/2ndQuadrant/repmgr/issues/53 .
2015-03-31 10:28:34 +09:00
Ian Barwick fec65bde3d Fix typo in -?/--help output 2015-03-27 18:09:41 +09:00
Ian Barwick 4863ea98bc Bump specfile version number 2015-03-27 17:42:55 +09:00
Ian Barwick c4505248b0 doc: Minor README/FAQ rewording 2015-03-27 11:34:52 +09:00
Ian Barwick 5774d86ac7 Remove not-yet-existent 2.0.3 release items 2015-03-27 11:05:40 +09:00
Ian Barwick 29e7733152 Prepare devel branch for promotion to master 2015-03-26 11:50:22 +09:00
Ian Barwick b64385bee8 Fix HISTORY item 2015-03-26 11:46:28 +09:00
Ian Barwick 419ce28d3d Remove old README 2015-03-26 11:44:09 +09:00
Ian Barwick 90cc6a5cb4 Add note about --initdb-no-pwprompt 2015-03-26 11:43:24 +09:00
Ian Barwick 1b175ddfcf Update FAILOVER.rst 2015-03-26 11:40:51 +09:00
Ian Barwick eabe618738 FAQ fixes and updates 2015-03-26 11:07:18 +09:00
Ian Barwick 3e621f43d1 Use 100 as the default priority; 0 or less means node will never be promoted 2015-03-26 10:38:20 +09:00
Ian Barwick 15a531fed8 Update function description 2015-03-24 19:36:31 +09:00
Ian Barwick 96255b988a Remove unused function
And standardized nomenclature on "master" rather than "primary".
2015-03-24 14:29:54 +09:00
Ian Barwick 8de0deddf9 Change "primary" to "master"
Personally I prefer "primary", but repmgr uses "master" so let's consolidate
on one version of the terminology for clarity.
2015-03-24 14:06:39 +09:00
Ian Barwick bd19a2c868 Improve handling of event logging in rempgrd
Provide the master connection if available, and if not enable
create_event_record() to skip trying to write to the database,
but execute the notification program if defined.
2015-03-24 13:40:39 +09:00
Ian Barwick 2cadb3424d Don't try and log events when no master connection available 2015-03-24 12:48:02 +09:00
Ian Barwick bfe4585b91 rempgr -> repmgr 2015-03-24 11:32:50 +09:00
Ian Barwick 230773d626 Merge pull request #52 from centromere/repmgr
Fix typo in README.rst
2015-03-24 10:45:02 +09:00
John Galt 81b7b3bae7 Fixed typo 2015-03-23 21:08:48 -04:00
Germ van Ek 8cfc26d3ea Added postgresql-9.4 to debian control file 2015-03-24 10:03:56 +09:00
Ian Barwick 5b1a4d0ef1 Merge pull request #51 from gerben-van-eck/repmgr
Added postgresql-9.4 to debian control file
2015-03-24 09:59:57 +09:00
Germ van Ek 22423aa51a Added postgresql-9.4 to debian control file 2015-03-23 16:53:04 +01:00
Ian Barwick 98df2a5891 Fix recovery_min_apply_delay handling
- rename --min-recovery-apply-delay to --recovery-min-apply-delay
- ensure server version is 9.4 or later before writing
  recovery_min_apply_delay to recovery.conf.

This fixes changes introduced in 653e11c2a7
(the parameter was subsequently renamed).

Also reallocate the '-r' parameter to --rsync-only, which is probably
more useful.
2015-03-23 17:50:51 +09:00
Ian Barwick 6f61c8285b Add note about pg_basebackup -X s
We already provide a facility to pass arbitrary options to pg_basebackup.
2015-03-23 15:56:50 +09:00
Ian Barwick 0875b2aafa Change 'ignore_external_config_files' to a command line option
It's only used when cloning a standby and has more in common with
--fast-checkpoint
2015-03-23 15:24:01 +09:00
Ian Barwick 3e2c9ed410 Support --fast-checkpoint 2015-03-23 12:18:17 +09:00
Ian Barwick 5b4f832f3b Only allow --rsync-only option in combination with STANDBY CLONE 2015-03-20 15:16:55 +09:00
Ian Barwick 66844d057a Rename 'need_a_node' to 'config_file_required' 2015-03-20 14:56:02 +09:00
Ian Barwick f096cca84f Fix parameter checking for STANDBY CLONE
Previous check for the master host was ineffective. We'd be better off explicitly
requiring at least hostname, database and usernames for the master rather
than relying on whatever defaults were in place when STANDBY CLONE is
run, especially as dbname and username are used in recovery.conf.
2015-03-20 14:47:04 +09:00
Ian Barwick 0fbb83262f Rename t_configuration_options member 'pgctl_options' to 'pg_ctl_options'
Change is to make it match the actual configuration item.
2015-03-20 11:02:32 +09:00
Ian Barwick a0a3ef58b0 Remove item "Timeline increases when promoting a standby"
Covered by `pg_ctl promote`.
2015-03-20 10:42:07 +09:00
Ian Barwick b007fc8b39 3.0rc4 2015-03-19 23:28:40 +09:00
Ian Barwick ae19c9bd5d Only execute pg_stop_backup() if pg_start_backup() was previously executed
It's not a problem per-se but produces some unnecessary and possibly
confusing errors.
2015-03-19 23:19:34 +09:00
Ian Barwick 1b4a8917ca Transfer hint in error message to its own log notice 2015-03-19 23:12:39 +09:00
Ian Barwick ce66a7c2d2 We shouldn't terminate with an error if no event record could be created
Event records are advisory and non-critical; there may be paths
where we're not able to connect to a valid master and hence unable
to write a record. (If an 'event_notification_command' is defined,
this should serve as a backup notification of the event).
2015-03-19 23:09:29 +09:00
Ian Barwick 9a3196b671 Add a hint if 'standby register' fails due to insert error 2015-03-19 23:01:31 +09:00
Ian Barwick 46a3082055 No need for log_event() function 2015-03-19 22:49:50 +09:00
Ian Barwick ebabc68f8a Add recovery.conf file location and contents to debugging output 2015-03-19 22:15:45 +09:00
Ian Barwick c757985640 primary -> master
For consistency
2015-03-19 11:26:47 +09:00
Ian Barwick 172a3d90cf Terminate rather than destroy 2015-03-19 09:55:20 +09:00
Ian Barwick 86d24759a0 In configuration check, check that 'archive_command' is not empty 2015-03-18 16:07:34 +09:00
Ian Barwick 7bd54b5a70 3.0rc3 2015-03-17 23:16:18 +09:00
Ian Barwick 3e04c8e720 Event logging and notifications 2015-03-17 20:10:00 +09:00
Ian Barwick 7f98bb7aec Create event record for rempgrd termination
Also fix a few incorrect exit codes.
2015-03-17 19:08:59 +09:00
Ian Barwick 9e2736be4c Remove superfluous configuration check
Also add note about configuration parsing failure and event logging.
2015-03-17 18:41:17 +09:00
Ian Barwick 4b3966d6a7 Update HISTORY 2015-03-17 16:07:04 +09:00
Ian Barwick 5a1036cea2 Update and rework repmgr.conf.sample 2015-03-17 14:13:46 +09:00
Ian Barwick e21448831d Standardize configuration error messages for 'failover' parameter.
Better to fail with an error than assume a default value if an
unrecognized value is detected.
2015-03-17 08:19:29 +09:00