Greg Smith
f928edf897
Improve parameter validation, logging, and error
...
handling in repmgrd
2011-02-24 18:13:16 -05:00
Greg Smith
59b7b90169
Update README with better two-node example output
2011-02-23 09:08:08 -05:00
Greg Smith
3cdd6a57fd
Add more info level logging around database activity
2011-02-23 08:42:49 -05:00
Greg Smith
9c6288993b
Fix double free in standby clone
2011-02-23 07:26:39 -05:00
Greg Smith
2675101330
Make PGPASSWORD substitution in recovery.conf optional
2011-02-23 07:19:36 -05:00
Greg Smith
02daccd6e7
Wrap use of PQconnectdbParams, add proper error
...
checking and logging when the connection fails.
2011-02-23 06:44:10 -05:00
Greg Smith
18ef5b3cf3
Convert more uses of fprintf to use logger
2011-02-23 05:59:09 -05:00
Greg Smith
3b2203c38c
Make verbose command line option useful on top of
...
the new logging infrastructure.
2011-02-23 05:29:29 -05:00
Greg Smith
a98aec12e1
And one more round of astyle work
2011-02-15 00:57:12 -05:00
Greg Smith
757457ad85
Fix merge error that removed setting keywords
2011-02-15 00:55:50 -05:00
Greg Smith
45022debc6
Break out error codes, cleanup header files and HISTORY
2011-02-15 00:43:36 -05:00
Greg Smith
f6618a01c7
Post-merge astyle run
2011-02-15 00:14:13 -05:00
Greg Smith
20af4ffc2c
Merge commit '3ef1fa126d9c9b9ba3b29deab7f67218cdf7ce10'
...
Conflicts:
.gitignore
Makefile
README.rst
check_dir.c
config.c
config.h
dbutils.h
repmgr.c
repmgr.conf
repmgr.h
repmgrd.c
2011-02-15 00:06:01 -05:00
Greg Smith
3ef1fa126d
astyle run against Heroku code
2011-02-14 21:51:14 -05:00
Greg Smith
0130420947
astyle cleanup run after recent merges
2011-02-10 18:55:51 -05:00
Greg Smith
1d32133d49
Update all the copyrights to add 2011
2011-02-10 18:33:02 -05:00
Greg Smith
1be62fa6b2
Fix use of "options" broken by recent merging
2011-02-10 18:26:44 -05:00
Greg Smith
78b925ea54
Unify use of error codes across all exit statements
2011-02-10 17:49:34 -05:00
Charles Duffy
7e7c45c61d
exit with status 2 if manual work is needed during standby_clone
2011-02-10 17:08:43 -05:00
Charles Duffy
a02cd43115
repmgr: treat directory access errors during standby clone as failure
2011-02-10 17:03:00 -05:00
Charles Duffy
a67688f198
minor format string and comment fixes (add missing newlines, fix english usage, format string argument order)
2011-02-10 17:01:59 -05:00
Charles Duffy
f74b806e4f
repmgr: exit with nonzero status on obvious errors
2011-02-10 17:00:33 -05:00
Gabriele Bartolini
556f256bb6
Now standby clone command accepts configuration file - for logging purposes only
2011-02-10 16:08:07 -05:00
Gabriele Bartolini
83eee2ed96
added some messages to the clone command
2011-02-10 16:08:07 -05:00
Gabriele Bartolini
cb36aaddff
- Added \n
2011-02-10 16:08:07 -05:00
Gabriele Bartolini
3146d2c676
fixed some bugs with standby clone
2011-02-10 16:08:07 -05:00
Gabriele Bartolini
3f1c6a5852
Removed any sprintf/strcpy call and use snprintf/strncpy - Fixed bug with tblspc_dir - added debug messages after every query
2011-02-10 16:08:07 -05:00
Gabriele Bartolini
716a0ae9d3
removed any malloc operation, added t_runtime_options struct
2011-02-10 16:05:03 -05:00
Gabriele Bartolini
7a3be3a2f9
Cleaned log messages (\n at the end of every line)
2011-02-10 15:58:55 -05:00
Gabriele Bartolini
f6a6632169
Added new log system to both repmgr and repmgrd. Needs cleaning, but it is a good starting point
2011-02-10 15:58:55 -05:00
Gabriele Bartolini
2c1eafd7a9
first alpha version for syslog support
2011-02-10 15:56:10 -05:00
trbs
52313a2d6e
made rsync_options configurable
2011-02-10 15:06:09 -05:00
trbs
814863edf2
use struct for config file information
2011-02-10 15:06:09 -05:00
trbs
03ed0e692a
fix strformat order reversal in error message
2011-02-10 15:00:44 -05:00
Daniel Farina
ce21291418
Issue a message when a configuration file is passed unnecessarily
...
Simply intends to set expectations around the fact that a config file
is not used *and* doesn't affect anything material about the standby
clone command.
This uses a notion of "logging level" (like NOTICE) that is not yet
seen this program, but I'll probably introduce that soon.
Signed-off-by: Daniel Farina <daniel@heroku.com >
2011-02-10 03:19:36 -08:00
Daniel Farina
4b007bf4bc
Use a better check for when to issue an error message
...
This patch changes raising the error "You need to use connection
parameters to the master when issuing a STANDBY CLONE command." to
only occur when no host (a global variable, that is abused for at
least two purposes, but is okay in this case) is passed, rather than
when no config file is passed, which is fine for standby clone (which
itself is a wrapper for rsync)
Signed-off-by: Daniel Farina <daniel@heroku.com >
2011-02-10 03:19:30 -08:00
Daniel Farina
da82829659
Avoid checking config file when performing standby clone action
...
Signed-off-by: Daniel Farina <daniel@heroku.com >
2011-02-10 02:10:58 -08:00
Dan Farina
ebbb7c3a47
Fix more quoting: used an overly-quoted copy
...
Signed-off-by: Dan Farina <daniel@heroku.com >
2011-02-07 03:59:18 -08:00
Dan Farina
630d716819
Use the proper freeing method
...
As according to
http://www.postgresql.org/docs/9.0/static/libpq-exec.html#LIBPQ-EXEC-ESCAPE-STRING
Signed-off-by: Dan Farina <daniel@heroku.com >
2011-02-07 03:59:18 -08:00
Dan Farina
c1b84fe9fc
Make some fast hacks to quote schema names
...
Signed-off-by: Dan Farina <drfarina@acm.org >
2011-02-07 03:59:18 -08:00
Dan Farina
bfd3aed33b
Fix a myriad of problems introduced by merging
...
Signed-off-by: Dan Farina <drfarina@acm.org >
2011-02-06 18:32:49 -08:00
Dan Farina
c356f9e97f
Merge remote-tracking branch 'tbrs/master' into heroku
...
Grab the configuration struct changes. It was expeditious to un-do
some of my by-hand line-wrapping that avoids 80 character limit,
though.
Conflicts:
config.c
config.h
repmgr.c
repmgr.h
repmgrd.c
2011-02-04 18:35:56 -08:00
Dan Farina
a52ebc412c
Merge remote-tracking branch 'origin/master' into heroku
...
The Great Whitespace Reconciliation
Conflicts:
check_dir.c
config.c
dbutils.c
repmgr.c
repmgr.h
repmgrd.c
Signed-off-by: Dan Farina <drfarina@acm.org >
2011-02-04 18:27:28 -08:00
trbs
57169f51cf
made rsync_options configurable
2011-01-08 01:46:39 +01:00
trbs
fc2405f17d
use struct for config file information
2011-01-07 01:36:46 +01:00
trbs
cb1192b912
fix strformat order reversal in error message
2010-12-23 15:02:02 +01:00
Dan Farina
156714f3f1
Fix quoting misbehavior
...
Move the single quote in the formatting string to the end of the line.
Signed-off-by: Dan Farina <drfarina@acm.org >
2010-12-23 01:04:05 -08:00
Dan Farina
dd5ac660bf
Comments and cleanup
...
Signed-off-by: Dan Farina <drfarina@acm.org >
2010-12-23 00:55:39 -08:00
Dan Farina
3a430397dc
Avoid overwriting the new password-in-recovery.conf formatting
...
Previously: did that work, then threw it away/overwrote it.
Signed-off-by: Dan Farina <drfarina@acm.org >
2010-12-23 00:55:39 -08:00
Dan Farina
1f098c60ac
Remove dead-ish code
...
This is a leftover after having fixed various problems in the verbose
output here.
Signed-off-by: Dan Farina <drfarina@acm.org >
2010-12-23 00:55:39 -08:00