github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-22 22:56:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity
209 Commits 43 Branches 68 Tags
e04ba8bea5f9617bb1d4a26c04b4fa8ce83d3748
Commit Graph

116 Commits

Author SHA1 Message Date
Jaime Casanova
e04ba8bea5 Add "--checksum" in rsync when using "--force" 
If the user don't put that option in rsync_options using of "--force"
could be unsafe.
While the probability of failures because of this are low they aren't
zero.
 2015-02-10 20:46:06 -05:00
Jaime Casanova
031f9aedcc Options -F -I -v doesn't accept arguments, which means that on 
getopt_long shouldn't be marked with the colon (:) character.

This has been wrong since day one, so backpatching all the way until
1.1
 2013-01-13 16:42:04 -05:00
Jaime Casanova
8ee715b657 Make repmgr compatible with FreeBSD. 
We need to #include <sys/wait.h> to get WEXITSTATUS()
 2012-09-15 17:45:38 -05:00
Jaime Casanova
c2344fe843 When we have more command-line arguments than we should have we 
need to show that last value and we should use only optind for that
instead of optind+1
 2012-09-15 17:41:49 -05:00
Jaime Casanova
30b124e91f STANDBY CLONE should be run by a SUPERUSER, otherwise we won't be able 
to retrieve data_directory and the other parameters we need by
querying the database.
 2012-06-12 09:40:38 -05:00
Jaime Casanova
c00fa9f9ba Fix a switch in which a "break" was missing that makes always that --force option 
was used end up in the default section and error.
 2012-04-19 12:18:21 -05:00
Jaime Casanova
c3bffce379 Run astyle to format code before tagging the release 2012-04-11 10:35:37 -05:00
Jaime Casanova
78aea00a6d Avoid to show what segments are needed for this backup if the rsync failed 2012-04-11 10:34:38 -05:00
Jaime Casanova
91601204b5 Remove last argument from log_err, left in commit 9b8fb7e960. 
Also rephrase the sentence

Reported by Jeroen Dekkers
 2011-11-28 17:26:19 -05:00
Jaime Casanova
c91ddc2f5e Fix a wrong message. 
It was saying the problem is the version of the PostgreSQL server while
it actually is because the MASTER REGISTER command was running on a
standby node
 2011-11-10 09:30:42 -05:00
Jaime Casanova
72f74dd7a7 Fix a typo introduced in commit 94c9c3a5c6 2011-11-03 12:54:55 -05:00
Jaime Casanova
901d07fa92 Improve performance of the repl_status view 2011-10-20 23:20:03 -05:00
Jaime Casanova
94c9c3a5c6 Let the clone happen in a session with synchronous_commit off. This 
is because in pg 9.1 the default configuration can easily allow sync
rep to be activated even if no standby is present and will block
pg_start_backup() and pg_stop_backup() in that case.

Also remove a second connection we were opening to execute
pg_stop_backup(), i'm not sure why that was there but now it was
a problem because it was another session and not the one we set here.
 2011-10-03 13:56:31 -05:00
Cédric Villemain
3af5243bcc Fix rsync return code test 2011-08-24 09:14:22 -05:00
Cédric Villemain
14e49d41c2 Add --ignore-rsync-warning command line option 
This fix the rsync return code in case there are vanished files.

Common situation are DROPed tables and TEMPorary object deletion and
are handled by PostgreSQL.
But as it may exist situation where an external process delete files in
the PGDATA the flag is off by default.

XXX 2 items :

 * is -I a good choice ? maybe we need to prevent future --ignore-foo and
   add something like : --ignore=rsync_warning -I rsync_warning
 * the warning message is not enough explicit with the risk involved by
   --force usage
 2011-08-22 00:32:40 -05:00
Cédric Villemain
1bd8a703c8 Fix getopt for ignore-rsync-warning 
The change was loosed during merge and not checked in master/
 2011-06-06 20:56:45 -04:00
Greg Smith
3ca0f2db06 Fix unapplied astyle. Closes gh-26. 2011-04-05 17:21:48 -04:00
Jaime Casanova
58ec43106e Options -U, -R and -p shouldn't be mandatory. Fix by checking if the string 
is empty before use.
 2011-03-02 02:44:01 -05:00
Greg Smith
f928edf897 Improve parameter validation, logging, and error 
handling in repmgrd
 2011-02-24 18:13:16 -05:00
Greg Smith
59b7b90169 Update README with better two-node example output 2011-02-23 09:08:08 -05:00
Greg Smith
3cdd6a57fd Add more info level logging around database activity 2011-02-23 08:42:49 -05:00
Greg Smith
9c6288993b Fix double free in standby clone 2011-02-23 07:26:39 -05:00
Greg Smith
2675101330 Make PGPASSWORD substitution in recovery.conf optional 2011-02-23 07:19:36 -05:00
Greg Smith
02daccd6e7 Wrap use of PQconnectdbParams, add proper error 
checking and logging when the connection fails.
 2011-02-23 06:44:10 -05:00
Greg Smith
18ef5b3cf3 Convert more uses of fprintf to use logger 2011-02-23 05:59:09 -05:00
Greg Smith
3b2203c38c Make verbose command line option useful on top of 
the new logging infrastructure.
 2011-02-23 05:29:29 -05:00
Greg Smith
a98aec12e1 And one more round of astyle work 2011-02-15 00:57:12 -05:00
Greg Smith
757457ad85 Fix merge error that removed setting keywords 2011-02-15 00:55:50 -05:00
Greg Smith
45022debc6 Break out error codes, cleanup header files and HISTORY 2011-02-15 00:43:36 -05:00
Greg Smith
f6618a01c7 Post-merge astyle run 2011-02-15 00:14:13 -05:00
Greg Smith
20af4ffc2c Merge commit '3ef1fa126d9c9b9ba3b29deab7f67218cdf7ce10' 
Conflicts:
	.gitignore
	Makefile
	README.rst
	check_dir.c
	config.c
	config.h
	dbutils.h
	repmgr.c
	repmgr.conf
	repmgr.h
	repmgrd.c
 2011-02-15 00:06:01 -05:00
Greg Smith
3ef1fa126d astyle run against Heroku code 2011-02-14 21:51:14 -05:00
Greg Smith
0130420947 astyle cleanup run after recent merges 2011-02-10 18:55:51 -05:00
Greg Smith
1d32133d49 Update all the copyrights to add 2011 2011-02-10 18:33:02 -05:00
Greg Smith
1be62fa6b2 Fix use of "options" broken by recent merging 2011-02-10 18:26:44 -05:00
Greg Smith
78b925ea54 Unify use of error codes across all exit statements 2011-02-10 17:49:34 -05:00
Charles Duffy
7e7c45c61d exit with status 2 if manual work is needed during standby_clone 2011-02-10 17:08:43 -05:00
Charles Duffy
a02cd43115 repmgr: treat directory access errors during standby clone as failure 2011-02-10 17:03:00 -05:00
Charles Duffy
a67688f198 minor format string and comment fixes (add missing newlines, fix english usage, format string argument order) 2011-02-10 17:01:59 -05:00
Charles Duffy
f74b806e4f repmgr: exit with nonzero status on obvious errors 2011-02-10 17:00:33 -05:00
Gabriele Bartolini
556f256bb6 Now standby clone command accepts configuration file - for logging purposes only 2011-02-10 16:08:07 -05:00
Gabriele Bartolini
83eee2ed96 added some messages to the clone command 2011-02-10 16:08:07 -05:00
Gabriele Bartolini
cb36aaddff - Added \n 2011-02-10 16:08:07 -05:00
Gabriele Bartolini
3146d2c676 fixed some bugs with standby clone 2011-02-10 16:08:07 -05:00
Gabriele Bartolini
3f1c6a5852 Removed any sprintf/strcpy call and use snprintf/strncpy - Fixed bug with tblspc_dir - added debug messages after every query 2011-02-10 16:08:07 -05:00
Gabriele Bartolini
716a0ae9d3 removed any malloc operation, added t_runtime_options struct 2011-02-10 16:05:03 -05:00
Gabriele Bartolini
7a3be3a2f9 Cleaned log messages (\n at the end of every line) 2011-02-10 15:58:55 -05:00
Gabriele Bartolini
f6a6632169 Added new log system to both repmgr and repmgrd. Needs cleaning, but it is a good starting point 2011-02-10 15:58:55 -05:00
Gabriele Bartolini
2c1eafd7a9 first alpha version for syslog support 2011-02-10 15:56:10 -05:00
trbs
52313a2d6e made rsync_options configurable 2011-02-10 15:06:09 -05:00