github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-23 07:06:30 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Ensure pg_replslot directory is cleaned up after "standby clone" with rsync

Browse Source 
This ensures the directory is in the same state as it would be
after cloning the standby with pg_basebackup, i.e. empty.
This commit is contained in:
Ian Barwick
2015-11-30 15:31:43 +09:00
parent 6ae5401df0
commit 5ccf89ad9b
1 changed files with 30 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
repmgr.c
View File

@@ -1761,13 +1761,20 @@ stop_backup:
exit(retval);
}
/*
* Remove existing WAL from the target directory, since
* rsync's --exclude option doesn't do it.
* Clean up any $PGDATA subdirectories which may contain
* files which won't be removed by rsync and which could
* be stale or are otherwise not required
*/
if (runtime_options.force)
if (runtime_options.rsync_only && runtime_options.force)
{
char script[MAXLEN];
/*
* Remove any existing WAL from the target directory, since
* rsync's --exclude option doesn't do it.
*/
maxlen_snprintf(script, "rm -rf %s/pg_xlog/*",
local_data_directory);
r = system(script);
@@ -1777,6 +1784,26 @@ stop_backup:
local_data_directory);
exit(ERR_BAD_RSYNC);
}
/*
* Remove any replication slot directories; this matches the
* behaviour a base backup, which would result in an empty
* pg_replslot directory.
*
* NOTE: watch out for any changes in the replication
* slot directory name (as of 9.4: "pg_replslot") and
* functionality of replication slots
*/
maxlen_snprintf(script, "rm -rf %s/pg_replslot/*",
local_data_directory);
r = system(script);
if (r != 0)
{
log_err(_("unable to empty replication slot directory %s/pg_replslot/\n"),
local_data_directory);
exit(ERR_BAD_RSYNC);
}
}
/* Finally, write the recovery.conf file */