github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-22 22:56:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Check that there is no exclusive backup taking place while we perform

Browse Source 
a switchover.

We've found that this can cause some issues with postgres control
metadata (could be a postgres bug) so best thing is *not* no switchover
if there's a backup taking place.

It's also a bad idea from an architectual point of view, as a switchover
is supposed to be planed, so why perform it when we are taking backups.

GitHub #476.
This commit is contained in:
Martín Marqués
2018-07-17 14:00:37 -03:00
committed by Ian Barwick
parent ef35d071bf
commit 8f13a66aaa
3 changed files with 43 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
dbutils.c
View File

@@ -3953,7 +3953,31 @@ connection_ping(PGconn *conn)
return;
}
/*
* Function that checks if the primary is in exclusive backup mode.
* We'll use this when executing an action can conflict with an exclusive
* backup.
*/
bool
server_not_in_exclusive_backup_mode(PGconn *conn)
{
PGresult *res = PQexec(conn, "SELECT pg_is_in_backup()");
if (PQresultStatus(res) != PGRES_TUPLES_OK)
{
log_error(_("unable to retrieve information regarding backup mode of node"));
log_detail("%s", PQerrorMessage(conn));
PQclear(res);
return false;
}
if (strcmp(PQgetvalue(res, 0, 0), "t") == 0)
{
log_warning(_("node is in exclusive backup mode"));
return false;
}
return true;
}
/* ==================== */
/* monitoring functions */

1
dbutils.h
View File

@@ -467,6 +467,7 @@ int wait_connection_availability(PGconn *conn, long long timeout);
bool is_server_available(const char *conninfo);
bool is_server_available_params(t_conninfo_param_list *param_list);
void connection_ping(PGconn *conn);
bool server_not_in_exclusive_backup_mode(PGconn *conn);
/* monitoring functions */
void

18
repmgr-action-standby.c
View File

@@ -2911,6 +2911,24 @@ do_standby_switchover(void)
exit(ERR_DB_QUERY);
}
/*
* Check that there's no exclusive backups running on the primary.
* We don't want to end up damaging the backup and also leaving the server in an
* state where there's control data saying it's in backup mode but there's no
* backup_label in PGDATA.
* If the DBA wants to do the switchover anyway, he should first stop the
* backup that's running.
*/
if (!server_not_in_exclusive_backup_mode(remote_conn))
{
log_error(_("can't perform a switchover while primary server is in exclusive backup mode"));
log_hint(_("stop backup before attempting the switchover"));
PQfinish(remote_conn);
exit(ERR_SWITCHOVER_FAIL);
}
/*
* Check this standby is attached to the demotion candidate
* TODO: